[mmotm:master 124/394] mm/vmscan.c:410:15: error: 'shrinker_idr' undeclared; did you mean 'shrinker_list'?

[mmotm:master 124/394] mm/vmscan.c:410:15: error: 'shrinker_idr' undeclared; did you mean 'shrinker_list'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   b1da01df1aa700864692a49a7007fc96cc1da7d9
commit: f9ee2a2d698cd64d8032d56649e960a91bb98416 [124/394] mm: use special value SHRINKER_REGISTERING instead list_empty() check
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        git checkout f9ee2a2d698cd64d8032d56649e960a91bb98416
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the mmotm/master HEAD b1da01df1aa700864692a49a7007fc96cc1da7d9 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   mm/vmscan.c: In function 'register_shrinker_prepared':
>> mm/vmscan.c:410:15: error: 'shrinker_idr' undeclared (first use in this function); did you mean 'shrinker_list'?
     idr_replace(&shrinker_idr, shrinker, shrinker->id);
                  ^~~~~~~~~~~~
                  shrinker_list
   mm/vmscan.c:410:15: note: each undeclared identifier is reported only once for each function it appears in
>> mm/vmscan.c:410:47: error: 'struct shrinker' has no member named 'id'
     idr_replace(&shrinker_idr, shrinker, shrinker->id);
                                                  ^~

vim +410 mm/vmscan.c

   405	
   406	void register_shrinker_prepared(struct shrinker *shrinker)
   407	{
   408		down_write(&shrinker_rwsem);
   409		list_add_tail(&shrinker->list, &shrinker_list);
 > 410		idr_replace(&shrinker_idr, shrinker, shrinker->id);
   411		up_write(&shrinker_rwsem);
   412	}
   413	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6369 bytes --]

Re: [mmotm:master 124/394] mm/vmscan.c:410:15: error: 'shrinker_idr' undeclared; did you mean 'shrinker_list'?

[Kirill Tkhai]

There is v3 with #ifdef, it fixes the problem.

Thanks,
Kirill

On 10.08.2018 08:54, kbuild test robot wrote:
> tree:   git://git.cmpxchg.org/linux-mmotm.git master
> head:   b1da01df1aa700864692a49a7007fc96cc1da7d9
> commit: f9ee2a2d698cd64d8032d56649e960a91bb98416 [124/394] mm: use special value SHRINKER_REGISTERING instead list_empty() check
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout f9ee2a2d698cd64d8032d56649e960a91bb98416
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> Note: the mmotm/master HEAD b1da01df1aa700864692a49a7007fc96cc1da7d9 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>    mm/vmscan.c: In function 'register_shrinker_prepared':
>>> mm/vmscan.c:410:15: error: 'shrinker_idr' undeclared (first use in this function); did you mean 'shrinker_list'?
>      idr_replace(&shrinker_idr, shrinker, shrinker->id);
>                   ^~~~~~~~~~~~
>                   shrinker_list
>    mm/vmscan.c:410:15: note: each undeclared identifier is reported only once for each function it appears in
>>> mm/vmscan.c:410:47: error: 'struct shrinker' has no member named 'id'
>      idr_replace(&shrinker_idr, shrinker, shrinker->id);
>                                                   ^~
> 
> vim +410 mm/vmscan.c
> 
>    405	
>    406	void register_shrinker_prepared(struct shrinker *shrinker)
>    407	{
>    408		down_write(&shrinker_rwsem);
>    409		list_add_tail(&shrinker->list, &shrinker_list);
>  > 410		idr_replace(&shrinker_idr, shrinker, shrinker->id);
>    411		up_write(&shrinker_rwsem);
>    412	}
>    413	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>