From: Dennis Zhou <dennisszhou@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Christopher Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>,
kernel-team@fb.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: add percpu populated pages count to meminfo
Date: Tue, 7 Aug 2018 08:22:08 -0700 [thread overview]
Message-ID: <20180807152207.GC59704@dennisz-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20180807151146.GB3978217@devbig004.ftw2.facebook.com>
Hi Tejun,
On Tue, Aug 07, 2018 at 08:11:46AM -0700, Tejun Heo wrote:
> Hello,
>
> On Tue, Aug 07, 2018 at 02:12:06PM +0000, Christopher Lameter wrote:
> > > @@ -121,6 +122,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
> > > (unsigned long)VMALLOC_TOTAL >> 10);
> > > show_val_kb(m, "VmallocUsed: ", 0ul);
> > > show_val_kb(m, "VmallocChunk: ", 0ul);
> > > + show_val_kb(m, "PercpuPopulated:", pcpu_nr_populated_pages());
> >
> > Populated? Can we avoid this for simplicities sake: "Percpu"?
> >
> > We do not count pages that are not present elsewhere either and those
> > counters do not have "populated" in them.
>
> Yeah, let's do "Percpu".
>
Sounds good, I've dropped populated.
Thanks,
Dennis
next prev parent reply other threads:[~2018-08-07 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 0:56 Dennis Zhou
2018-08-07 13:18 ` Vlastimil Babka
2018-08-07 15:03 ` Dennis Zhou
2018-08-07 14:12 ` Christopher Lameter
2018-08-07 15:11 ` Tejun Heo
2018-08-07 15:22 ` Dennis Zhou [this message]
2018-08-07 15:21 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180807152207.GC59704@dennisz-mbp.dhcp.thefacebook.com \
--to=dennisszhou@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox