From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by kanga.kvack.org (Postfix) with ESMTP id EE1EB6B0008 for ; Mon, 6 Aug 2018 16:34:39 -0400 (EDT) Received: by mail-ed1-f69.google.com with SMTP id b25-v6so4570726eds.17 for ; Mon, 06 Aug 2018 13:34:39 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id u42-v6si5107457edm.404.2018.08.06.13.34.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Aug 2018 13:34:38 -0700 (PDT) Date: Mon, 6 Aug 2018 22:34:37 +0200 From: Michal Hocko Subject: Re: WARNING in try_charge Message-ID: <20180806203437.GK10003@dhcp22.suse.cz> References: <0000000000006350880572c61e62@google.com> <20180806174410.GB10003@dhcp22.suse.cz> <20180806175627.GC10003@dhcp22.suse.cz> <078bde8d-b1b5-f5ad-ed23-0cd94b579f9e@i-love.sakura.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <078bde8d-b1b5-f5ad-ed23-0cd94b579f9e@i-love.sakura.ne.jp> Sender: owner-linux-mm@kvack.org List-ID: To: Tetsuo Handa Cc: syzbot , cgroups@vger.kernel.org, dvyukov@google.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, vdavydov.dev@gmail.com On Tue 07-08-18 05:26:23, Tetsuo Handa wrote: > On 2018/08/07 2:56, Michal Hocko wrote: > > So the oom victim indeed passed the above force path after the oom > > invocation. But later on hit the page fault path and that behaved > > differently and for some reason the force path hasn't triggered. I am > > wondering how could we hit the page fault path in the first place. The > > task is already killed! So what the hell is going on here. > > > > I must be missing something obvious here. > > > YOU ARE OBVIOUSLY MISSING MY MAIL! > > I already said this is "mm, oom: task_will_free_mem(current) should ignore MMF_OOM_SKIP for once." > problem which you are refusing at https://www.spinics.net/lists/linux-mm/msg133774.html . > And you again ignored my mail. Very sad... Your suggestion simply didn't make much sense. There is nothing like first check is different from the rest. -- Michal Hocko SUSE Labs