linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Rashmica Gupta <rashmica.g@gmail.com>
Cc: kbuild-all@01.org, toshi.kani@hpe.com, tglx@linutronix.de,
	akpm@linux-foundation.org, bp@suse.de, brijesh.singh@amd.com,
	thomas.lendacky@amd.com, jglisse@redhat.com,
	gregkh@linuxfoundation.org, baiyaowei@cmss.chinamobile.com,
	dan.j.williams@intel.com, mhocko@suse.com,
	iamjoonsoo.kim@lge.com, vbabka@suse.cz, malat@debian.org,
	pasha.tatashin@oracle.com, bhelgaas@google.com,
	osalvador@techadventures.net, yasu.isimatu@gmail.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RESEND PATCH] resource: Merge resources on a node when hot-adding memory
Date: Sat, 4 Aug 2018 01:08:44 +0800	[thread overview]
Message-ID: <201808040000.ni7EXkjP%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180803064357.3757-1-rashmica.g@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]

Hi Rashmica,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc7]
[cannot apply to next-20180802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rashmica-Gupta/resource-Merge-resources-on-a-node-when-hot-adding-memory/20180803-221205
config: x86_64-randconfig-x000-201830 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   mm/memory_hotplug.c: In function 'add_memory':
>> mm/memory_hotplug.c:1191:3: error: implicit declaration of function 'release_mem_region_adjustable'; did you mean 'release_mem_region'? [-Werror=implicit-function-declaration]
      release_mem_region_adjustable(&iomem_resource, start, size);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      release_mem_region
   cc1: some warnings being treated as errors

vim +1191 mm/memory_hotplug.c

  1179	
  1180	int __ref add_memory(int nid, u64 start, u64 size)
  1181	{
  1182		struct resource *res;
  1183		int ret;
  1184	
  1185		res = register_memory_resource(nid, start, size);
  1186		if (IS_ERR(res))
  1187			return PTR_ERR(res);
  1188	
  1189		ret = add_memory_resource(nid, start, size, memhp_auto_online);
  1190		if (ret < 0) {
> 1191			release_mem_region_adjustable(&iomem_resource, start, size);
  1192			kfree(res);
  1193		}
  1194		return ret;
  1195	}
  1196	EXPORT_SYMBOL_GPL(add_memory);
  1197	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34496 bytes --]

  reply	other threads:[~2018-08-03 17:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  6:43 Rashmica Gupta
2018-08-03 17:08 ` kbuild test robot [this message]
2018-08-03 17:25 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201808040000.ni7EXkjP%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=baiyaowei@cmss.chinamobile.com \
    --cc=bhelgaas@google.com \
    --cc=bp@suse.de \
    --cc=brijesh.singh@amd.com \
    --cc=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jglisse@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=malat@debian.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@techadventures.net \
    --cc=pasha.tatashin@oracle.com \
    --cc=rashmica.g@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=toshi.kani@hpe.com \
    --cc=vbabka@suse.cz \
    --cc=yasu.isimatu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox