From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>,
vdavydov.dev@gmail.com, mhocko@suse.com, aryabinin@virtuozzo.com,
ying.huang@intel.com, penguin-kernel@I-love.SAKURA.ne.jp,
shakeelb@google.com, jbacik@fb.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Use special value SHRINKER_REGISTERING instead list_empty() check
Date: Fri, 3 Aug 2018 16:03:18 -0700 [thread overview]
Message-ID: <20180803230318.GB23284@bombadil.infradead.org> (raw)
In-Reply-To: <20180803155120.0d65511b46c100565b4f8a2c@linux-foundation.org>
On Fri, Aug 03, 2018 at 03:51:20PM -0700, Andrew Morton wrote:
> On Fri, 03 Aug 2018 18:36:14 +0300 Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
> > The patch introduces a special value SHRINKER_REGISTERING to use instead
> > of list_empty() to detect a semi-registered shrinker.
>
> All this isn't terribly nice. Why can't we avoid installing the
> shrinker into the idr until it is fully initialized?
I haven't reviewed the current state of the code in question, but the
IDR allows you to store a NULL in order to allocate an ID. One should
then either call idr_remove() in order to release the ID or idr_replace()
once the object has been fully initialised.
Another way to potentially accomplish the same thing is to use
idr_alloc_u32 which will assign the ID immediately before inserting
the pointer into the IDR. This only works if the caller can initialise
everything but the ID, and can handle an ENOMEM.
next prev parent reply other threads:[~2018-08-03 23:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 15:36 Kirill Tkhai
2018-08-03 22:51 ` Andrew Morton
2018-08-03 23:03 ` Matthew Wilcox [this message]
2018-08-04 18:42 ` Kirill Tkhai
2018-08-05 0:03 ` Matthew Wilcox
2018-08-05 5:30 ` Kirill Tkhai
2018-08-05 12:50 ` Matthew Wilcox
2018-08-06 8:55 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803230318.GB23284@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=jbacik@fb.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox