From: Andrew Morton <akpm@linux-foundation.org>
To: Yang Shi <shy828301@gmail.com>
Cc: chenjie6@huawei.com, linux-mm@kvack.org, tj@kernel.org,
lizefan@huawei.com, chen jie <"chen jie@chenjie6"@huwei.com>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] mm:bugfix check return value of ioremap_prot
Date: Thu, 2 Aug 2018 14:02:22 -0700 [thread overview]
Message-ID: <20180802140222.5957911883678f8271f636aa@linux-foundation.org> (raw)
In-Reply-To: <CAHbLzkpj9chSMFWWhSb1hTL86rWdys3a=2oHgLjp_e-mDGF1Sw@mail.gmail.com>
On Thu, 2 Aug 2018 09:47:52 -0700 Yang Shi <shy828301@gmail.com> wrote:
> On Thu, Aug 2, 2018 at 12:37 AM, <chenjie6@huawei.com> wrote:
> > From: chen jie <chen jie@chenjie6@huwei.com>
> >
> > ioremap_prot can return NULL which could lead to an oops
>
> What oops? You'd better to have the oops information in your commit log.
Doesn't matter much - the code is clearly buggy.
Looking at the callers, I have suspicions about
fs/proc/base.c:environ_read(). It's assuming that access_remote_vm()
returns an errno. But it doesn't - it returns number of bytes copied.
Alexey, could you please take a look? While in there, I'd suggest
adding some return value documentation to __access_remote_vm() and
access_remote_vm(). Thanks.
next prev parent reply other threads:[~2018-08-02 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 7:37 chenjie6
2018-08-02 16:47 ` Yang Shi
2018-08-02 21:02 ` Andrew Morton [this message]
2018-08-03 12:47 ` Alexey Dobriyan
2018-08-03 23:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802140222.5957911883678f8271f636aa@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc="chen jie@chenjie6"@huwei.com \
--cc=adobriyan@gmail.com \
--cc=chenjie6@huawei.com \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=shy828301@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox