From: Johannes Weiner <hannes@cmpxchg.org>
To: Roman Gushchin <guro@fb.com>
Cc: linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Tejun Heo <tj@kernel.org>,
kernel-team@fb.com, linux-kernel@vger.kernel.org,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] mm, oom: refactor oom_kill_process()
Date: Wed, 1 Aug 2018 13:32:06 -0400 [thread overview]
Message-ID: <20180801173206.GB11386@cmpxchg.org> (raw)
In-Reply-To: <20180730180100.25079-3-guro@fb.com>
On Mon, Jul 30, 2018 at 11:00:59AM -0700, Roman Gushchin wrote:
> oom_kill_process() consists of two logical parts: the first one is
> responsible for considering task's children as a potential victim and
> printing the debug information. The second half is responsible for
> sending SIGKILL to all tasks sharing the mm struct with the given victim.
>
> This commit splits oom_kill_process() with an intention to re-use the the
> second half: __oom_kill_process().
>
> The cgroup-aware OOM killer will kill multiple tasks belonging to the
> victim cgroup. We don't need to print the debug information for the each
> task, as well as play with task selection (considering task's children),
> so we can't use the existing oom_kill_process().
>
> Link: http://lkml.kernel.org/r/20171130152824.1591-2-guro@fb.com
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Acked-by: David Rientjes <rientjes@google.com>
> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: David Rientjes <rientjes@google.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Michal Hocko <mhocko@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This is pretty straight-forward.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2018-08-01 17:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 18:00 [PATCH 0/3] introduce memory.oom.group Roman Gushchin
2018-07-30 18:00 ` [PATCH 1/3] mm: introduce mem_cgroup_put() helper Roman Gushchin
2018-07-31 8:45 ` Michal Hocko
2018-07-31 14:58 ` Shakeel Butt
2018-08-01 5:53 ` Michal Hocko
2018-08-01 17:31 ` Johannes Weiner
2018-07-30 18:00 ` [PATCH 2/3] mm, oom: refactor oom_kill_process() Roman Gushchin
2018-08-01 17:32 ` Johannes Weiner [this message]
2018-07-30 18:01 ` [PATCH 3/3] mm, oom: introduce memory.oom.group Roman Gushchin
2018-07-31 9:07 ` Michal Hocko
2018-08-01 1:14 ` Roman Gushchin
2018-08-01 5:55 ` Michal Hocko
2018-08-01 17:48 ` Johannes Weiner
2018-08-01 17:50 ` Johannes Weiner
2018-07-31 1:49 ` [PATCH 0/3] " David Rientjes
2018-07-31 15:54 ` Johannes Weiner
2018-07-31 23:51 ` Roman Gushchin
2018-08-01 21:51 ` David Rientjes
2018-08-01 22:47 ` Roman Gushchin
2018-08-06 21:34 ` David Rientjes
2018-08-07 0:30 ` Roman Gushchin
2018-08-07 22:34 ` David Rientjes
2018-08-08 10:59 ` Michal Hocko
2018-08-09 20:10 ` David Rientjes
2018-08-10 7:03 ` Michal Hocko
2018-08-19 23:26 ` cgroup aware oom killer (was Re: [PATCH 0/3] introduce memory.oom.group) David Rientjes
2018-08-20 19:05 ` Roman Gushchin
2018-08-02 8:00 ` [PATCH 0/3] introduce memory.oom.group Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801173206.GB11386@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox