From: Michal Hocko <mhocko@kernel.org>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: Oscar Salvador <osalvador@techadventures.net>,
akpm@linux-foundation.org, vbabka@suse.cz,
mgorman@techsingularity.net, aaron.lu@intel.com,
iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v3 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid()
Date: Thu, 26 Jul 2018 18:43:04 +0200 [thread overview]
Message-ID: <20180726164304.GP28386@dhcp22.suse.cz> (raw)
In-Reply-To: <20180726151420.uigttpoclcka6h4h@xakep.localdomain>
On Thu 26-07-18 11:14:20, Pavel Tatashin wrote:
> Hi Oscar,
>
> Below is updated patch, with comment about OpenGrok and Acked-by Michal added.
>
> Thank you,
> Pavel
>
> >From cca1b083d78d0ff99cce6dfaf12f6380d76390c7 Mon Sep 17 00:00:00 2001
> From: Pavel Tatashin <pasha.tatashin@oracle.com>
> Date: Thu, 26 Jul 2018 00:01:41 +0200
> Subject: [PATCH] mm: access zone->node via zone_to_nid() and zone_set_nid()
>
> zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to
> have inline functions to access this field in order to avoid ifdef's in
> c files.
>
> OpenGrok was used to find places where zone->node is accessed. A public one
> is available here: http://src.illumos.org/source/
I assume that tool uses some pattern matching or similar so steps to use
the tool to get your results would be more helpful. This is basically
the same thing as coccinelle generated patches.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-07-26 16:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 22:01 [PATCH v3 0/5] Refactor free_area_init_core and add free_area_init_core_hotplug osalvador
2018-07-25 22:01 ` [PATCH v3 1/5] mm/page_alloc: Move ifdefery out of free_area_init_core osalvador
2018-07-25 22:01 ` [PATCH v3 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid() osalvador
2018-07-26 8:05 ` Michal Hocko
2018-07-26 8:12 ` Oscar Salvador
2018-07-26 15:14 ` Pavel Tatashin
2018-07-26 16:43 ` Michal Hocko [this message]
2018-07-26 17:18 ` Pavel Tatashin
2018-07-26 17:52 ` Michal Hocko
2018-07-26 17:55 ` Pavel Tatashin
2018-07-26 19:15 ` Oscar Salvador
2018-07-25 22:01 ` [PATCH v3 3/5] mm/page_alloc: Inline function to handle CONFIG_DEFERRED_STRUCT_PAGE_INIT osalvador
2018-07-26 15:17 ` Pavel Tatashin
2018-07-25 22:01 ` [PATCH v3 4/5] mm/page_alloc: Move initialization of node and zones to an own function osalvador
2018-07-26 8:12 ` Michal Hocko
2018-07-26 15:35 ` Pavel Tatashin
2018-07-26 19:15 ` Oscar Salvador
2018-07-25 22:01 ` [PATCH v3 5/5] mm/page_alloc: Introduce memhotplug version of free_area_init_core osalvador
2018-07-26 7:38 ` Oscar Salvador
2018-07-26 12:02 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726164304.GP28386@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=pasha.tatashin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox