From: Oscar Salvador <osalvador@techadventures.net>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, mhocko@suse.com,
linux-mm@kvack.org, dan.j.williams@intel.com, jack@suse.cz,
jglisse@redhat.com, jrdr.linux@gmail.com, bhe@redhat.com,
gregkh@linuxfoundation.org, vbabka@suse.cz,
richard.weiyang@gmail.com, dave.hansen@intel.com,
rientjes@google.com, mingo@kernel.org,
abdhalee@linux.vnet.ibm.com, mpe@ellerman.id.au
Subject: Re: [PATCH 1/3] mm: make memmap_init a proper function
Date: Thu, 26 Jul 2018 09:50:40 +0200 [thread overview]
Message-ID: <20180726075040.GB22028@techadventures.net> (raw)
In-Reply-To: <20180724235520.10200-2-pasha.tatashin@oracle.com>
On Tue, Jul 24, 2018 at 07:55:18PM -0400, Pavel Tatashin wrote:
> memmap_init is sometimes a macro sometimes a function based on
> __HAVE_ARCH_MEMMAP_INIT. It is only a function on ia64. Make
> memmap_init a weak function instead, and let ia64 redefine it.
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Looks good, and it is easier to read.
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Thanks
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-07-26 7:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 23:55 [PATCH 0/3] memmap_init_zone improvements Pavel Tatashin
2018-07-24 23:55 ` [PATCH 1/3] mm: make memmap_init a proper function Pavel Tatashin
2018-07-26 7:50 ` Oscar Salvador [this message]
2018-07-24 23:55 ` [PATCH 2/3] mm: calculate deferred pages after skipping mirrored memory Pavel Tatashin
2018-07-25 1:12 ` Andrew Morton
2018-07-25 1:19 ` Pavel Tatashin
2018-07-25 1:31 ` Andrew Morton
2018-07-25 1:46 ` Pavel Tatashin
2018-07-25 21:30 ` Andrew Morton
2018-07-26 15:39 ` Pavel Tatashin
2018-07-25 12:14 ` Oscar Salvador
2018-07-25 13:32 ` Pavel Tatashin
2018-07-24 23:55 ` [PATCH 3/3] mm: move mirrored memory specific code outside of memmap_init_zone Pavel Tatashin
2018-07-25 1:18 ` Andrew Morton
2018-07-25 1:31 ` Pavel Tatashin
2018-07-25 11:48 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726075040.GB22028@techadventures.net \
--to=osalvador@techadventures.net \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=steven.sistare@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox