From: Matthew Wilcox <willy@infradead.org>
To: David Rientjes <rientjes@google.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
kirill@shutemov.name, hughd@google.com, aaron.lu@intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: thp: remove use_zero_page sysfs knob
Date: Sat, 21 Jul 2018 20:51:56 -0700 [thread overview]
Message-ID: <20180722035156.GA12125@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1807201401390.231119@chino.kir.corp.google.com>
On Fri, Jul 20, 2018 at 02:05:52PM -0700, David Rientjes wrote:
> The huge zero page can be reclaimed under memory pressure and, if it is,
> it is attempted to be allocted again with gfp flags that attempt memory
> compaction that can become expensive. If we are constantly under memory
> pressure, it gets freed and reallocated millions of times always trying to
> compact memory both directly and by kicking kcompactd in the background.
>
> It likely should also be per node.
Have you benchmarked making the non-huge zero page per-node?
next prev parent reply other threads:[~2018-07-22 3:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 18:13 Yang Shi
2018-07-20 19:32 ` Andrew Morton
2018-07-20 20:02 ` David Rientjes
2018-07-20 20:37 ` Yang Shi
2018-07-20 21:05 ` David Rientjes
2018-07-20 23:49 ` Yang Shi
2018-07-22 3:51 ` Matthew Wilcox [this message]
2018-07-23 20:28 ` David Rientjes
2018-07-23 21:33 ` David Rientjes
2018-07-23 21:49 ` Yang Shi
2018-07-24 9:08 ` Kirill A. Shutemov
2018-07-24 20:32 ` David Rientjes
2018-07-20 21:06 ` Kirill A. Shutemov
2018-07-20 23:51 ` Yang Shi
2018-07-23 20:31 ` David Rientjes
2018-07-23 21:52 ` Yang Shi
2018-07-23 23:14 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180722035156.GA12125@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox