From: Andrew Morton <akpm@linux-foundation.org>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: kirill@shutemov.name, hughd@google.com, rientjes@google.com,
aaron.lu@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: thp: remove use_zero_page sysfs knob
Date: Fri, 20 Jul 2018 12:32:43 -0700 [thread overview]
Message-ID: <20180720123243.6dfc95ba061cd06e05c0262e@linux-foundation.org> (raw)
In-Reply-To: <1532110430-115278-1-git-send-email-yang.shi@linux.alibaba.com>
On Sat, 21 Jul 2018 02:13:50 +0800 Yang Shi <yang.shi@linux.alibaba.com> wrote:
> By digging into the original review, it looks use_zero_page sysfs knob
> was added to help ease-of-testing and give user a way to mitigate
> refcounting overhead.
>
> It has been a few years since the knob was added at the first place, I
> think we are confident that it is stable enough. And, since commit
> 6fcb52a56ff60 ("thp: reduce usage of huge zero page's atomic counter"),
> it looks refcounting overhead has been reduced significantly.
>
> Other than the above, the value of the knob is always 1 (enabled by
> default), I'm supposed very few people turn it off by default.
>
> So, it sounds not worth to still keep this knob around.
Probably OK. Might not be OK, nobody knows.
It's been there for seven years so another six months won't kill us.
How about as an intermediate step we add a printk("use_zero_page is
scheduled for removal. Please contact linux-mm@kvack.org if you need
it").
next prev parent reply other threads:[~2018-07-20 19:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 18:13 Yang Shi
2018-07-20 19:32 ` Andrew Morton [this message]
2018-07-20 20:02 ` David Rientjes
2018-07-20 20:37 ` Yang Shi
2018-07-20 21:05 ` David Rientjes
2018-07-20 23:49 ` Yang Shi
2018-07-22 3:51 ` Matthew Wilcox
2018-07-23 20:28 ` David Rientjes
2018-07-23 21:33 ` David Rientjes
2018-07-23 21:49 ` Yang Shi
2018-07-24 9:08 ` Kirill A. Shutemov
2018-07-24 20:32 ` David Rientjes
2018-07-20 21:06 ` Kirill A. Shutemov
2018-07-20 23:51 ` Yang Shi
2018-07-23 20:31 ` David Rientjes
2018-07-23 21:52 ` Yang Shi
2018-07-23 23:14 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720123243.6dfc95ba061cd06e05c0262e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aaron.lu@intel.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox