From: Pavel Machek <pavel@ucw.cz>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Waiman Long <longman@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Miklos Szeredi <mszeredi@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Larry Woodman <lwoodman@redhat.com>,
"Wangkai (Kevin,C)" <wangkai86@huawei.com>,
linux-mm@kvack.org, Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v5 0/6] fs/dcache: Track & limit # of negative dentries
Date: Sat, 14 Jul 2018 19:35:16 +0200 [thread overview]
Message-ID: <20180714173516.uumlhs4wgfgrlc32@devuan> (raw)
In-Reply-To: <20180703091821.oiywpdxd6rhtxl4p@quack2.suse.cz>
> > Yes, "should be". I could understand that the presence of huge
> > nunmbers of -ve dentries could result in undesirable reclaim of
> > pagecache, etc. Triggering oom-killings is very bad, and presumably
> > has the same cause.
> >
> > Before we go and add a large amount of code to do the shrinker's job
> > for it, we should get a full understanding of what's going wrong. Is
> > it because the dentry_lru had a mixture of +ve and -ve dentries?
> > Should we have a separate LRU for -ve dentries? Are we appropriately
> > aging the various dentries? etc.
> >
> > It could be that tuning/fixing the current code will fix whatever
> > problems inspired this patchset.
>
> What I think is contributing to the problems and could lead to reclaim
> oddities is the internal fragmentation of dentry slab cache. Dentries are
> relatively small, you get 21 per page on my system, so if trivial to
> reclaim negative dentries get mixed with a small amount of unreclaimable
> positive dentries, you can get a lot of pages in dentry slab cache that are
> unreclaimable.
Could we allocate -ve entries from separate slab?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2018-07-14 17:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1530510723-24814-1-git-send-email-longman@redhat.com>
[not found] ` <CA+55aFyH6dHw-7R3364dn32J4p7kxT=TqmnuozCn9_Bz-MHhxQ@mail.gmail.com>
2018-07-02 21:18 ` Andrew Morton
2018-07-02 22:21 ` Matthew Wilcox
2018-07-02 22:31 ` Linus Torvalds
2018-07-02 22:34 ` James Bottomley
2018-07-02 22:54 ` Linus Torvalds
2018-07-02 23:03 ` Linus Torvalds
2018-07-02 23:19 ` Andrew Morton
2018-07-02 23:28 ` Linus Torvalds
2018-07-03 1:38 ` Waiman Long
2018-07-03 9:18 ` Jan Kara
2018-07-14 17:35 ` Pavel Machek [this message]
2018-07-14 18:00 ` Linus Torvalds
2018-07-14 18:34 ` Al Viro
2018-07-14 18:36 ` Al Viro
2018-07-14 18:43 ` Linus Torvalds
2018-07-18 16:01 ` Waiman Long
2018-07-03 1:11 ` Waiman Long
2018-07-03 13:48 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180714173516.uumlhs4wgfgrlc32@devuan \
--to=pavel@ucw.cz \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=lwoodman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=mszeredi@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkai86@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox