From: Oscar Salvador <osalvador@techadventures.net>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, mhocko@suse.com,
linux-mm@kvack.org, dan.j.williams@intel.com, jack@suse.cz,
jglisse@redhat.com, jrdr.linux@gmail.com, bhe@redhat.com,
gregkh@linuxfoundation.org, vbabka@suse.cz,
richard.weiyang@gmail.com, dave.hansen@intel.com,
rientjes@google.com, mingo@kernel.org
Subject: Re: [PATCH v3 2/2] mm/sparse: start using sparse_init_nid(), and remove old code
Date: Mon, 2 Jul 2018 16:04:40 +0200 [thread overview]
Message-ID: <20180702140440.GA10207@techadventures.net> (raw)
In-Reply-To: <20180702020417.21281-3-pasha.tatashin@oracle.com>
On Sun, Jul 01, 2018 at 10:04:17PM -0400, Pavel Tatashin wrote:
> Change sprase_init() to only find the pnum ranges that belong to a specific
> node and call sprase_init_nid() for that range from sparse_init().
>
> Delete all the code that became obsolete with this change.
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
This looks like an improvement to me.
It also makes the code much easier to follow and to understand.
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-07-02 14:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 2:04 [PATCH v3 0/2] sparse_init rewrite Pavel Tatashin
2018-07-02 2:04 ` [PATCH v3 1/2] mm/sparse: add sparse_init_nid() Pavel Tatashin
2018-07-02 2:11 ` Baoquan He
2018-07-02 2:18 ` Pavel Tatashin
2018-07-02 2:31 ` Baoquan He
2018-07-02 2:43 ` Pavel Tatashin
2018-07-02 2:53 ` Baoquan He
2018-07-02 3:03 ` Pavel Tatashin
2018-07-02 3:14 ` Baoquan He
2018-07-02 3:17 ` Baoquan He
2018-07-02 3:28 ` Pavel Tatashin
2018-07-02 3:42 ` Baoquan He
2018-07-02 2:56 ` Baoquan He
2018-07-02 3:05 ` Pavel Tatashin
2018-07-02 19:59 ` Dave Hansen
2018-07-02 20:29 ` Pavel Tatashin
2018-07-05 13:39 ` Dave Hansen
2018-07-09 14:31 ` Pavel Tatashin
2018-07-02 2:04 ` [PATCH v3 2/2] mm/sparse: start using sparse_init_nid(), and remove old code Pavel Tatashin
2018-07-02 14:04 ` Oscar Salvador [this message]
2018-07-02 19:47 ` Dave Hansen
2018-07-02 19:54 ` Pavel Tatashin
2018-07-02 20:00 ` Dave Hansen
2018-07-02 20:12 ` Pavel Tatashin
2018-07-02 16:20 ` [PATCH v3 0/2] sparse_init rewrite Dave Hansen
2018-07-02 17:46 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702140440.GA10207@techadventures.net \
--to=osalvador@techadventures.net \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=steven.sistare@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox