* [PATCH] writeback: update stale account_page_redirty() comment
@ 2018-06-25 17:15 Greg Thelen
2018-06-26 12:06 ` Jan Kara
2018-07-02 15:57 ` Tejun Heo
0 siblings, 2 replies; 3+ messages in thread
From: Greg Thelen @ 2018-06-25 17:15 UTC (permalink / raw)
To: Tejun Heo, Andrew Morton; +Cc: Jan Kara, linux-mm, linux-kernel, Greg Thelen
commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into
bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in
account_page_redirty(). Update comment to track that change.
BDI_DIRTIED => WB_DIRTIED
BDI_WRITTEN => WB_WRITTEN
Signed-off-by: Greg Thelen <gthelen@google.com>
---
mm/page-writeback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 337c6afb3345..6551d3b0dc30 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2490,8 +2490,8 @@ EXPORT_SYMBOL(__set_page_dirty_nobuffers);
/*
* Call this whenever redirtying a page, to de-account the dirty counters
- * (NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied), so that they match the written
- * counters (NR_WRITTEN, BDI_WRITTEN) in long term. The mismatches will lead to
+ * (NR_DIRTIED, WB_DIRTIED, tsk->nr_dirtied), so that they match the written
+ * counters (NR_WRITTEN, WB_WRITTEN) in long term. The mismatches will lead to
* systematic errors in balanced_dirty_ratelimit and the dirty pages position
* control.
*/
--
2.18.0.rc2.346.g013aa6912e-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] writeback: update stale account_page_redirty() comment
2018-06-25 17:15 [PATCH] writeback: update stale account_page_redirty() comment Greg Thelen
@ 2018-06-26 12:06 ` Jan Kara
2018-07-02 15:57 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2018-06-26 12:06 UTC (permalink / raw)
To: Greg Thelen; +Cc: Tejun Heo, Andrew Morton, Jan Kara, linux-mm, linux-kernel
On Mon 25-06-18 10:15:26, Greg Thelen wrote:
> commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into
> bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in
> account_page_redirty(). Update comment to track that change.
> BDI_DIRTIED => WB_DIRTIED
> BDI_WRITTEN => WB_WRITTEN
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> mm/page-writeback.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 337c6afb3345..6551d3b0dc30 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2490,8 +2490,8 @@ EXPORT_SYMBOL(__set_page_dirty_nobuffers);
>
> /*
> * Call this whenever redirtying a page, to de-account the dirty counters
> - * (NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied), so that they match the written
> - * counters (NR_WRITTEN, BDI_WRITTEN) in long term. The mismatches will lead to
> + * (NR_DIRTIED, WB_DIRTIED, tsk->nr_dirtied), so that they match the written
> + * counters (NR_WRITTEN, WB_WRITTEN) in long term. The mismatches will lead to
> * systematic errors in balanced_dirty_ratelimit and the dirty pages position
> * control.
> */
> --
> 2.18.0.rc2.346.g013aa6912e-goog
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] writeback: update stale account_page_redirty() comment
2018-06-25 17:15 [PATCH] writeback: update stale account_page_redirty() comment Greg Thelen
2018-06-26 12:06 ` Jan Kara
@ 2018-07-02 15:57 ` Tejun Heo
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2018-07-02 15:57 UTC (permalink / raw)
To: Greg Thelen; +Cc: Andrew Morton, Jan Kara, linux-mm, linux-kernel
On Mon, Jun 25, 2018 at 10:15:26AM -0700, Greg Thelen wrote:
> commit 93f78d882865 ("writeback: move backing_dev_info->bdi_stat[] into
> bdi_writeback") replaced BDI_DIRTIED with WB_DIRTIED in
> account_page_redirty(). Update comment to track that change.
> BDI_DIRTIED => WB_DIRTIED
> BDI_WRITTEN => WB_WRITTEN
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-02 15:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-25 17:15 [PATCH] writeback: update stale account_page_redirty() comment Greg Thelen
2018-06-26 12:06 ` Jan Kara
2018-07-02 15:57 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox