From: osalvador@techadventures.net
To: akpm@linux-foundation.org
Cc: mhocko@suse.com, vbabka@suse.cz, pasha.tatashin@oracle.com,
Jonathan.Cameron@huawei.com, arbab@linux.vnet.ibm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v2 0/4] Small cleanup for memoryhotplug
Date: Fri, 22 Jun 2018 13:18:35 +0200 [thread overview]
Message-ID: <20180622111839.10071-1-osalvador@techadventures.net> (raw)
From: Oscar Salvador <osalvador@suse.de>
Hi,
I this is a small cleanup for the memhotplug's code.
A lot more could be done, but it is better to start somewhere.
I tried to unify/remove duplicated code.
The following is what this patchset does:
1) add_memory_resource() has code to allocate a node in case it was offline.
Since try_online_node has some code for that as well, I just made add_memory_resource() to
use that so we can remove duplicated code..
This is better explained in patch 1/4.
2) register_mem_sect_under_node() will be called only from link_mem_sections()
3) Make register_mem_sect_under_node() a callback of walk_memory_range()
4) Drop unnecessary checks from register_mem_sect_under_node()
I have done some tests and I could not see anything broken because of
this patchset.
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Tested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Changes since v1:
- Address issues/suggestions in the provided feedback (Pavel Tatashin)
- Rebased
Oscar Salvador (4):
mm/memory_hotplug: Make add_memory_resource use __try_online_node
mm/memory_hotplug: Call register_mem_sect_under_node
mm/memory_hotplug: Make register_mem_sect_under_node a cb of
walk_memory_range
mm/memory_hotplug: Drop unnecessary checks from
register_mem_sect_under_node
drivers/base/memory.c | 2 --
drivers/base/node.c | 49 ++++----------------------
include/linux/node.h | 12 ++++---
mm/memory_hotplug.c | 96 +++++++++++++++++++++++++--------------------------
4 files changed, 60 insertions(+), 99 deletions(-)
--
2.13.6
next reply other threads:[~2018-06-22 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 11:18 osalvador [this message]
2018-06-22 11:18 ` [PATCH v2 1/4] mm/memory_hotplug: Make add_memory_resource use __try_online_node osalvador
2018-06-22 11:18 ` [PATCH v2 2/4] mm/memory_hotplug: Call register_mem_sect_under_node osalvador
2018-06-22 11:18 ` [PATCH v2 3/4] mm/memory_hotplug: Make register_mem_sect_under_node a cb of walk_memory_range osalvador
2018-08-15 22:21 ` Andrew Morton
2018-08-16 6:15 ` Oscar Salvador
2018-08-16 17:20 ` Pasha Tatashin
2018-06-22 11:18 ` [PATCH v2 4/4] mm/memory_hotplug: Drop unnecessary checks from register_mem_sect_under_node osalvador
2018-06-22 21:16 ` [PATCH v2 0/4] Small cleanup for memoryhotplug Reza Arbab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622111839.10071-1-osalvador@techadventures.net \
--to=osalvador@techadventures.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=arbab@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox