From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: hughd@google.com, kirill.shutemov@linux.intel.com,
vbabka@suse.cz, akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: thp: register mm for khugepaged when merging vma for shmem
Date: Fri, 22 Jun 2018 01:10:08 +0300 [thread overview]
Message-ID: <20180621221008.r33hpd223kx2gv3a@kshutemo-mobl1> (raw)
In-Reply-To: <1529617247-126312-1-git-send-email-yang.shi@linux.alibaba.com>
On Fri, Jun 22, 2018 at 05:40:47AM +0800, Yang Shi wrote:
> When merging anonymous page vma, if the size of vam can fit in at least
s/vam/vma/
> one hugepage, the mm will be registered for khugepaged for collapsing
> THP in the future.
>
> But, it skips shmem vma. Doing so for shmem too when merging vma in
> order to increase the odd to collapse hugepage by khugepaged.
Good catch. Thanks.
I think the fix incomplete. We shouldn't require vma->anon_vma for shmem,
only for anonymous mappings. We don't support file-private THPs.
> Also increase the count of shmem THP collapse. It looks missed before.
Separate patch, please.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-06-21 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 21:40 Yang Shi
2018-06-21 22:10 ` Kirill A. Shutemov [this message]
2018-06-21 22:24 ` Yang Shi
2018-06-21 22:49 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621221008.r33hpd223kx2gv3a@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox