From: Michal Hocko <mhocko@kernel.org>
To: Jason Baron <jbaron@akamai.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Mel Gorman <mgorman@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-api@vger.kernel.org, emunson@mgebm.net
Subject: Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT
Date: Wed, 13 Jun 2018 11:13:55 +0200 [thread overview]
Message-ID: <20180613091355.GI13364@dhcp22.suse.cz> (raw)
In-Reply-To: <5a9398f4-453c-5cb5-6bbc-f20c3affc96a@akamai.com>
On Tue 12-06-18 10:11:33, Jason Baron wrote:
[...]
> Ok, I share the concern that there is a chance that userspace is relying
> on MADV_DONTNEED not free'ing locked memory. In that case, what if we
> introduce a MADV_DONTNEED_FORCE, which does everything that
> MADV_DONTNEED currently does but in addition will also free mlock areas.
What about other types of vmas that are not allowed to MADV_DONTNEED?
_FORCE suggests that the user of the API know what he is doing so why
shouldn't we allow unmapping hugetlb pages or special PFNMAPS? Or do we
want to add MADV_DONTNEED_FORCE_FOR_REAL when somebody comes with
another usecase?
I agree with Vlastimil that adding new madvise mode for niche case
sounds like a bad idea so we should better be sure that a new flag has
a reasonable semantic. Just allow mlocked pages is more of a tweak than
a proper semantic. So making it force for real requires to analyze what
that would mean for other vmas which are excluded now.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-06-13 9:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 18:56 Jason Baron
2018-06-08 19:57 ` Andrew Morton
2018-06-08 20:55 ` Jason Baron
2018-06-09 11:51 ` kbuild test robot
2018-06-11 7:20 ` Michal Hocko
2018-06-11 14:51 ` Jason Baron
2018-06-11 15:03 ` Michal Hocko
2018-06-11 16:23 ` Jason Baron
2018-06-12 7:46 ` Michal Hocko
2018-06-12 14:11 ` Jason Baron
2018-06-13 6:32 ` Vlastimil Babka
2018-06-13 7:15 ` Michal Hocko
2018-06-13 7:51 ` Vlastimil Babka
2018-06-13 8:37 ` Michal Hocko
2018-06-15 19:36 ` Jason Baron
2018-06-20 11:00 ` Michal Hocko
2018-06-28 20:20 ` Jason Baron
2018-06-13 9:13 ` Michal Hocko [this message]
2018-06-15 19:28 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613091355.GI13364@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=emunson@mgebm.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=jbaron@akamai.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox