From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: Timofey Titovets <nefelim4ag@gmail.com>,
Linux Memory Management List <linux-mm@kvack.org>,
solee@os.korea.ac.kr, aarcange@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH V6 2/2 RESEND] ksm: replace jhash2 with faster hash
Date: Sun, 10 Jun 2018 08:38:39 +0300 [thread overview]
Message-ID: <20180610053838.GB20681@rapoport-lnx> (raw)
In-Reply-To: <CAGM2rebK=gNbcAwkmt7W9kwtd=QWoPRogQMaoXOv=bmX+_d+yw@mail.gmail.com>
On Thu, Jun 07, 2018 at 09:29:49PM -0400, Pavel Tatashin wrote:
> > With CONFIG_SYSFS=n there is nothing that will set ksm_run to anything but
> > zero and ksm_do_scan will never be called.
> >
>
> Unfortunatly, this is not so:
>
> In: /linux-master/mm/ksm.c
>
> 3143#else
> 3144 ksm_run = KSM_RUN_MERGE; /* no way for user to start it */
> 3145
> 3146#endif /* CONFIG_SYSFS */
>
> So, we do set ksm_run to run right from ksm_init() when CONFIG_SYSFS=n.
Huh, missed that one...
> I wonder if this is acceptible to only use xxhash when CONFIG_SYSFS=n ?
A bit unrelated to CONFIG_SYSFS, but rather for rare use-cases in general.
What will happen in the following scenario:
* The system has crc32c HW acceleration
* KSM chooses crc32c
* KSM runs with crc32c
* user removes crc32c HW acceleration module
If I understand correctly, we'll then fall back to pure SW crc32c
calculations, right?
> Thank you,
> Pavel
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2018-06-10 5:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 19:32 [PATCH V6 0/2 RESEND] KSM replace hash algo " Timofey Titovets
2018-04-18 19:32 ` [PATCH V6 1/2 RESEND] xxHash: create arch dependent 32/64-bit xxhash() Timofey Titovets
2018-04-18 19:32 ` [PATCH V6 2/2 RESEND] ksm: replace jhash2 with faster hash Timofey Titovets
2018-05-08 15:26 ` Claudio Imbrenda
2018-05-11 23:06 ` Timofey Titovets
2018-05-14 10:17 ` Claudio Imbrenda
2018-05-16 10:26 ` Timofey Titovets
2018-05-22 20:22 ` Pavel Tatashin
2018-05-23 13:45 ` Timofey Titovets
2018-05-23 14:24 ` Pavel Tatashin
2018-05-24 8:01 ` Timofey Titovets
2018-05-25 1:16 ` Pavel Tatashin
2018-05-26 20:25 ` [PATCH] " kbuild test robot
2018-05-26 21:06 ` kbuild test robot
2018-05-27 13:03 ` [PATCH V6 2/2 RESEND] " Mike Rapoport
2018-05-29 14:45 ` Pavel Tatashin
2018-06-07 8:58 ` Timofey Titovets
2018-06-07 11:52 ` Mike Rapoport
2018-06-08 1:29 ` Pavel Tatashin
2018-06-10 5:38 ` Mike Rapoport [this message]
2018-06-22 18:48 ` Pavel Tatashin
2018-06-25 8:48 ` Mike Rapoport
2018-09-13 10:35 ` Timofey Titovets
2018-09-13 18:01 ` Mike Rapoport
2018-09-13 18:10 ` Pasha Tatashin
-- strict thread matches above, loose matches on Subject: below --
2018-02-07 10:22 [PATCH V6 0/2 RESEND] KSM replace hash algo " Timofey Titovets
2018-02-07 10:22 ` [PATCH V6 2/2 RESEND] ksm: replace jhash2 " Timofey Titovets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180610053838.GB20681@rapoport-lnx \
--to=rppt@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nefelim4ag@gmail.com \
--cc=pasha.tatashin@oracle.com \
--cc=solee@os.korea.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox