From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id CE7696B0006 for ; Thu, 7 Jun 2018 06:43:01 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id p16-v6so380163pfn.7 for ; Thu, 07 Jun 2018 03:43:01 -0700 (PDT) Received: from huawei.com ([45.249.212.32]) by mx.google.com with ESMTPS id l1-v6si13485891pgo.68.2018.06.07.03.43.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jun 2018 03:43:00 -0700 (PDT) Date: Thu, 7 Jun 2018 11:42:45 +0100 From: Jonathan Cameron Subject: Re: [PATCH 0/4] Small cleanup for memoryhotplug Message-ID: <20180607114245.00001068@huawei.com> In-Reply-To: <20180601125321.30652-1-osalvador@techadventures.net> References: <20180601125321.30652-1-osalvador@techadventures.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: osalvador@techadventures.net, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, pasha.tatashin@oracle.com, linux-mm@kvack.org, Oscar Salvador On Fri, 1 Jun 2018 14:53:17 +0200 wrote: > From: Oscar Salvador > > > Hi, > > I wanted to give it a try and do a small cleanup in the memhotplug's code. > A lot more could be done, but I wanted to start somewhere. > I tried to unify/remove duplicated code. > > The following is what this patchset does: > > 1) add_memory_resource() has code to allocate a node in case it was offline. > Since try_online_node has some code for that as well, I just made add_memory_resource() to > use that so we can remove duplicated code.. > This is better explained in patch 1/4. > > 2) register_mem_sect_under_node() will be called only from link_mem_sections() > > 3) Get rid of link_mem_sections() in favour of walk_memory_range() with a callback to > register_mem_sect_under_node() > > 4) Drop unnecessary checks from register_mem_sect_under_node() > > > I have done some tests and I could not see anything broken because of > this patchset. Works fine with the patch set for arm64 I'm intermittently working on. Or at least I don't need to make any additional changes on top of what I currently have! Tested-by: Jonathan Cameron Thanks, Jonathan > > Oscar Salvador (4): > mm/memory_hotplug: Make add_memory_resource use __try_online_node > mm/memory_hotplug: Call register_mem_sect_under_node > mm/memory_hotplug: Get rid of link_mem_sections > mm/memory_hotplug: Drop unnecessary checks from > register_mem_sect_under_node > > drivers/base/memory.c | 2 - > drivers/base/node.c | 52 +++++--------------------- > include/linux/node.h | 21 +++++------ > mm/memory_hotplug.c | 101 ++++++++++++++++++++++++++------------------------ > 4 files changed, 71 insertions(+), 105 deletions(-) >