From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Tejun Heo <tj@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 1/4] mm,oom: Don't call schedule_timeout_killable() with oom_lock held.
Date: Thu, 7 Jun 2018 13:11:37 +0200 [thread overview]
Message-ID: <20180607111137.GK32433@dhcp22.suse.cz> (raw)
In-Reply-To: <1528369223-7571-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Thu 07-06-18 20:00:20, Tetsuo Handa wrote:
[...]
> @@ -4238,6 +4237,12 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask)
> /* Retry as long as the OOM killer is making progress */
> if (did_some_progress) {
> no_progress_loops = 0;
> + /*
> + * This schedule_timeout_*() serves as a guaranteed sleep for
> + * PF_WQ_WORKER threads when __zone_watermark_ok() == false.
> + */
> + if (!tsk_is_oom_victim(current))
> + schedule_timeout_uninterruptible(1);
> goto retry;
> }
Nacked-by: Michal Hocko <mhocko@suse.com>
as explainaed several times already. This moving code just to preserve
the current logic without any arguments to back them must stop finally.
We have way too much of this "just in case" code that nobody really
understands and others just pile on top. Seriously this is not how the
development should work.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-06-07 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 11:00 Tetsuo Handa
2018-06-07 11:00 ` [PATCH 2/4] mm,page_alloc: Move the short sleep to should_reclaim_retry() Tetsuo Handa
2018-06-07 11:13 ` Michal Hocko
2018-06-07 11:00 ` [PATCH 3/4] mm,oom: Simplify exception case handling in out_of_memory() Tetsuo Handa
2018-06-07 11:16 ` Michal Hocko
2018-06-22 18:59 ` David Rientjes
2018-06-07 11:00 ` [PATCH 4/4] mm,oom: Check pending victims earlier " Tetsuo Handa
2018-06-07 11:28 ` Michal Hocko
2018-06-07 11:11 ` Michal Hocko [this message]
2018-06-08 10:47 ` [PATCH 1/4] mm,oom: Don't call schedule_timeout_killable() with oom_lock held Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607111137.GK32433@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox