From: Michal Hocko <mhocko@kernel.org>
To: ufo19890607@gmail.com
Cc: akpm@linux-foundation.org, rientjes@google.com,
kirill.shutemov@linux.intel.com, aarcange@redhat.com,
penguin-kernel@I-love.SAKURA.ne.jp, guro@fb.com,
yang.s@alibaba-inc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
yuzhoujian <yuzhoujian@didichuxing.com>
Subject: Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header
Date: Mon, 4 Jun 2018 08:52:38 +0200 [thread overview]
Message-ID: <20180604065238.GE19202@dhcp22.suse.cz> (raw)
In-Reply-To: <1527940734-35161-2-git-send-email-ufo19890607@gmail.com>
On Sat 02-06-18 19:58:52, ufo19890607@gmail.com wrote:
> From: yuzhoujian <yuzhoujian@didichuxing.com>
>
> The dump_header does not print the memcg's name when the system
> oom happened, so users cannot locate the certain container which
> contains the task that has been killed by the oom killer.
>
> I follow the advices of David Rientjes and Michal Hocko, and refactor
> part of the oom report in a backwards compatible way. After this patch,
> users can get the memcg's path from the oom report and check the certain
> container more quickly.
I have earlier suggested that you split this into two parts. One to add
the missing information and the later to convert it to a single printk
output. Reducing the overhead from PATH_MAX to NAME_MAX is a good step
but it still really begs an example why we really insist on a single
printk and that should be in its own changelog.
Sorry if that was not clear previously.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-06-04 6:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 11:58 [PATCH v7 1/2] Add an array of const char and enum oom_constraint in memcontrol.h ufo19890607
2018-06-02 11:58 ` [PATCH v7 2/2] Refactor part of the oom report in dump_header ufo19890607
2018-06-03 12:49 ` Mike Rapoport
2018-06-04 1:58 ` 禹舟键
2018-06-04 2:41 ` 禹舟键
2018-06-04 4:58 ` Mike Rapoport
2018-06-04 6:25 ` 禹舟键
2018-06-08 9:53 ` 禹舟键
2018-06-10 5:12 ` Mike Rapoport
2018-06-11 7:07 ` Michal Hocko
2018-06-03 14:45 ` Tetsuo Handa
2018-06-04 6:52 ` Michal Hocko [this message]
2018-06-04 8:18 ` 禹舟键
2018-06-04 8:57 ` 禹舟键
2018-06-04 9:52 ` Michal Hocko
2018-06-04 12:13 ` 禹舟键
2018-06-04 12:17 ` Michal Hocko
2018-06-02 11:58 ` [PATCH v7 1/2] Add an array of const char and enum oom_constraint in memcontrol.h ufo19890607
2018-06-02 11:58 ` [PATCH v7 2/2] Refactor part of the oom report in dump_header ufo19890607
2018-06-04 6:48 ` [PATCH v7 1/2] Add an array of const char and enum oom_constraint in memcontrol.h Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604065238.GE19202@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=ufo19890607@gmail.com \
--cc=yang.s@alibaba-inc.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox