From: Matthew Wilcox <willy@infradead.org>
To: Huaisheng Ye <yehs2007@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, mhocko@suse.com,
vbabka@suse.cz, mgorman@techsingularity.net,
kstewart@linuxfoundation.org, alexander.levin@verizon.com,
gregkh@linuxfoundation.org, colyli@suse.de, chengnt@lenovo.com,
hehy1@lenovo.com, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org,
linux-btrfs@vger.kernel.org, Huaisheng Ye <yehs1@lenovo.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC PATCH v2 10/12] mm/zsmalloc: update usage of address zone modifiers
Date: Tue, 22 May 2018 04:22:30 -0700 [thread overview]
Message-ID: <20180522112230.GA5412@bombadil.infradead.org> (raw)
In-Reply-To: <1526916033-4877-11-git-send-email-yehs2007@gmail.com>
On Mon, May 21, 2018 at 11:20:31PM +0800, Huaisheng Ye wrote:
> @@ -343,7 +343,7 @@ static void destroy_cache(struct zs_pool *pool)
> static unsigned long cache_alloc_handle(struct zs_pool *pool, gfp_t gfp)
> {
> return (unsigned long)kmem_cache_alloc(pool->handle_cachep,
> - gfp & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
> + gfp & ~__GFP_ZONE_MOVABLE);
> }
This should be & ~GFP_ZONEMASK
Actually, we should probably have a function to clear those bits rather
than have every driver manipulating the gfp mask like this. Maybe
#define gfp_normal(gfp) ((gfp) & ~GFP_ZONEMASK)
return (unsigned long)kmem_cache_alloc(pool->handle_cachep,
- gfp & ~(__GFP_HIGHMEM|__GFP_MOVABLE));
+ gfp_normal(gfp));
next prev parent reply other threads:[~2018-05-22 11:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 15:20 [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD Huaisheng Ye
2018-05-21 15:20 ` [RFC PATCH v2 01/12] include/linux/gfp.h: " Huaisheng Ye
2018-05-21 15:20 ` [RFC PATCH v2 02/12] arch/x86/kernel/amd_gart_64: update usage of address zone modifiers Huaisheng Ye
2018-05-22 9:38 ` Christoph Hellwig
2018-05-22 10:17 ` [External] " Huaisheng HS1 Ye
2018-05-21 15:20 ` [RFC PATCH v2 03/12] arch/x86/kernel/pci-calgary_64: " Huaisheng Ye
2018-05-21 15:20 ` [RFC PATCH v2 04/12] drivers/iommu/amd_iommu: " Huaisheng Ye
2018-05-21 15:20 ` [RFC PATCH v2 05/12] include/linux/dma-mapping: " Huaisheng Ye
2018-05-21 15:30 ` Christoph Hellwig
2018-05-21 15:20 ` [RFC PATCH v2 10/12] mm/zsmalloc: " Huaisheng Ye
2018-05-22 11:22 ` Matthew Wilcox [this message]
2018-05-22 11:51 ` [External] " Huaisheng HS1 Ye
2018-05-21 15:20 ` [RFC PATCH v2 11/12] include/linux/highmem: update usage of movableflags Huaisheng Ye
2018-05-21 15:20 ` [RFC PATCH v2 12/12] arch/x86/include/asm/page.h: " Huaisheng Ye
2018-05-22 9:40 ` [RFC PATCH v2 00/12] get rid of GFP_ZONE_TABLE/BAD Christoph Hellwig
2018-05-22 18:37 ` Michal Hocko
2018-05-23 16:07 ` [External] " Huaisheng HS1 Ye
2018-05-24 12:18 ` Michal Hocko
2018-05-25 9:43 ` Huaisheng HS1 Ye
2018-05-28 13:37 ` Michal Hocko
2018-05-30 9:02 ` Huaisheng HS1 Ye
2018-05-30 9:11 ` Christoph Hellwig
2018-05-30 9:12 ` Michal Hocko
2018-05-24 5:19 ` Matthew Wilcox
2018-05-24 12:23 ` Michal Hocko
2018-05-24 15:18 ` Matthew Wilcox
2018-05-24 15:29 ` Michal Hocko
2018-05-25 12:00 ` Matthew Wilcox
2018-05-28 13:33 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522112230.GA5412@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.levin@verizon.com \
--cc=chengnt@lenovo.com \
--cc=colyli@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hehy1@lenovo.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=vbabka@suse.cz \
--cc=xen-devel@lists.xenproject.org \
--cc=yehs1@lenovo.com \
--cc=yehs2007@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox