From: Andrew Morton <akpm@linux-foundation.org>
To: Pavel Tatashin <pasha.tatashin@oracle.com>
Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mhocko@suse.com, linux-mm@kvack.org, mgorman@techsingularity.net,
mingo@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
fengguang.wu@intel.com, dennisszhou@gmail.com
Subject: Re: [PATCH v5] mm: don't allow deferred pages with NEED_PER_CPU_KM
Date: Tue, 15 May 2018 14:12:40 -0700 [thread overview]
Message-ID: <20180515141240.c7587ed53a0ff32ff984e3d2@linux-foundation.org> (raw)
In-Reply-To: <20180515175124.1770-1-pasha.tatashin@oracle.com>
On Tue, 15 May 2018 13:51:24 -0400 Pavel Tatashin <pasha.tatashin@oracle.com> wrote:
> It is unsafe to do virtual to physical translations before mm_init() is
> called if struct page is needed in order to determine the memory section
> number (see SECTION_IN_PAGE_FLAGS). This is because only in mm_init() we
> initialize struct pages for all the allocated memory when deferred struct
> pages are used.
>
> My recent fix exposed this problem,
"my recent fix" isn't very useful. I changed this to identify
c9e97a1997 ("mm: initialize pages on demand during boot"), yes?
>
> Fixes: 3a80a7fa7989 ("mm: meminit: initialise a subset of struct pages if CONFIG_DEFERRED_STRUCT_PAGE_INIT is set")
> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
And I added cc:stable.
next prev parent reply other threads:[~2018-05-15 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 17:51 Pavel Tatashin
2018-05-15 20:43 ` Michal Hocko
2018-05-15 21:12 ` Andrew Morton [this message]
2018-05-15 21:33 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515141240.c7587ed53a0ff32ff984e3d2@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=dennisszhou@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=steven.sistare@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox