From: Michal Hocko <mhocko@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: linux-mm <linux-mm@kvack.org>,
linuxarm@huawei.com, Pavel Tatashin <pasha.tatashin@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/memory_hotplug: Fix leftover use of struct page during hotplug
Date: Thu, 10 May 2018 14:02:00 +0200 [thread overview]
Message-ID: <20180510120200.GC5325@dhcp22.suse.cz> (raw)
In-Reply-To: <20180504175051.000009e8@huawei.com>
On Fri 04-05-18 17:50:51, Jonathan Cameron wrote:
[...]
> Exact path to the problem is as follows:
>
> mm/memory_hotplug.c : add_memory_resource
> The node is not online so we enter the
> if (new_node) twice, on the second such block there is a call to
> link_mem_sections which calls into
> drivers/node.c: link_mem_sections which calls
> drivers/node.c: register_mem_sect_under_node which calls
> get_nid_for_pfn and keeps trying until the output of that matches
> the expected node (passed all the way down from add_memory_resource)
I am sorry but I am still confused. Why don't we create sysfs files from
__add_pages
__add_section
hotplug_memory_register
register_mem_sect_under_node
The whole sysfs mess just deserves to die and be reworked completely.
Creating different pieces here and there is just a recipe for bugs
and unreviewable code </rant>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-05-10 12:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 8:53 Jonathan Cameron
2018-05-04 13:00 ` Pavel Tatashin
2018-05-04 16:08 ` Michal Hocko
2018-05-04 16:50 ` Jonathan Cameron
2018-05-10 12:02 ` Michal Hocko [this message]
2018-05-22 12:56 ` Michal Hocko
2018-05-23 13:54 ` Oscar Salvador
2018-05-23 14:16 ` Michal Hocko
2018-05-23 14:31 ` Oscar Salvador
2018-05-23 14:17 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510120200.GC5325@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=pasha.tatashin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox