From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Alexander Potapenko <glider@google.com>
Cc: dave.hansen@linux.intel.com, mingo@kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
mka@chromium.org, dvyukov@google.com, md@google.com
Subject: Re: [PATCH v2] x86/boot/64/clang: Use fixup_pointer() to access '__supported_pte_mask'
Date: Wed, 9 May 2018 00:44:45 +0300 [thread overview]
Message-ID: <20180508214445.lnqbct6dgrhyxp4a@black.fi.intel.com> (raw)
In-Reply-To: <20180508162829.7729-1-glider@google.com>
On Tue, May 08, 2018 at 04:28:29PM +0000, Alexander Potapenko wrote:
> @@ -196,7 +204,8 @@ unsigned long __head __startup_64(unsigned long physaddr,
>
> pmd_entry = __PAGE_KERNEL_LARGE_EXEC & ~_PAGE_GLOBAL;
> /* Filter out unsupported __PAGE_KERNEL_* bits: */
> - pmd_entry &= __supported_pte_mask;
> + mask_ptr = (pteval_t *)fixup_pointer(&__supported_pte_mask, physaddr);
Do we really need the cast here?
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-05-08 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 16:28 Alexander Potapenko
2018-05-08 16:49 ` Dave Hansen
2018-05-08 21:44 ` Kirill A. Shutemov [this message]
2018-05-09 9:16 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508214445.lnqbct6dgrhyxp4a@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=md@google.com \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox