From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f200.google.com (mail-wr0-f200.google.com [209.85.128.200]) by kanga.kvack.org (Postfix) with ESMTP id 9940A6B0010 for ; Fri, 4 May 2018 09:18:57 -0400 (EDT) Received: by mail-wr0-f200.google.com with SMTP id z7-v6so14005169wrg.11 for ; Fri, 04 May 2018 06:18:57 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id t38-v6si114262edh.161.2018.05.04.06.18.56 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 04 May 2018 06:18:56 -0700 (PDT) Date: Fri, 4 May 2018 15:18:54 +0200 From: Michal Hocko Subject: Re: [PATCH 3/3] mm/page_alloc: Fix typo in debug info of calculate_node_totalpages Message-ID: <20180504131854.GQ4535@dhcp22.suse.cz> References: <1525416729-108201-1-git-send-email-yehs1@lenovo.com> <1525416729-108201-4-git-send-email-yehs1@lenovo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525416729-108201-4-git-send-email-yehs1@lenovo.com> Sender: owner-linux-mm@kvack.org List-ID: To: Huaisheng Ye Cc: akpm@linux-foundation.org, linux-mm@kvack.org, vbabka@suse.cz, mgorman@techsingularity.net, pasha.tatashin@oracle.com, alexander.levin@verizon.com, hannes@cmpxchg.org, penguin-kernel@I-love.SAKURA.ne.jp, colyli@suse.de, chengnt@lenovo.com, linux-kernel@vger.kernel.org On Fri 04-05-18 14:52:09, Huaisheng Ye wrote: > realtotalpages is calculated by taking off absent_pages from > spanned_pages in every zone. > Debug message of calculate_node_totalpages shall accurately > indicate that it is real totalpages to avoid ambiguity. Is the printk actually useful? Why don't we simply remove it? You can get the information from /proc/zoneinfo so why to litter the dmesg output? > Signed-off-by: Huaisheng Ye > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 1b39db4..9d57db2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5967,7 +5967,7 @@ static void __meminit calculate_node_totalpages(struct pglist_data *pgdat, > > pgdat->node_spanned_pages = totalpages; > pgdat->node_present_pages = realtotalpages; > - printk(KERN_DEBUG "On node %d totalpages: %lu\n", pgdat->node_id, > + printk(KERN_DEBUG "On node %d realtotalpages: %lu\n", pgdat->node_id, > realtotalpages); > } > > -- > 1.8.3.1 > -- Michal Hocko SUSE Labs