From: Michal Hocko <mhocko@kernel.org>
To: Greg Thelen <gthelen@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memcg: mark memcg1_events static const
Date: Thu, 3 May 2018 21:33:19 +0200 [thread overview]
Message-ID: <20180503193319.GK4535@dhcp22.suse.cz> (raw)
In-Reply-To: <20180503192940.94971-1-gthelen@google.com>
On Thu 03-05-18 12:29:40, Greg Thelen wrote:
> Mark memcg1_events static: it's only used by memcontrol.c.
> And mark it const: it's not modified.
>
> Signed-off-by: Greg Thelen <gthelen@google.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 2bd3df3d101a..c9c7e5ea0e2f 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3083,7 +3083,7 @@ static int memcg_numa_stat_show(struct seq_file *m, void *v)
> #endif /* CONFIG_NUMA */
>
> /* Universal VM events cgroup1 shows, original sort order */
> -unsigned int memcg1_events[] = {
> +static const unsigned int memcg1_events[] = {
> PGPGIN,
> PGPGOUT,
> PGFAULT,
> --
> 2.17.0.441.gb46fe60e1d-goog
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2018-05-03 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 19:29 Greg Thelen
2018-05-03 19:33 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503193319.GK4535@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox