From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
linux-mm@kvack.org, Matthew Wilcox <mawilcox@microsoft.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Pekka Enberg <penberg@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v3 11/14] mm: Combine first two unions in struct page
Date: Mon, 30 Apr 2018 16:12:32 +0300 [thread overview]
Message-ID: <20180430131232.vvfkl62d4nwskcsa@black.fi.intel.com> (raw)
In-Reply-To: <20180430124216.GA27331@bombadil.infradead.org>
On Mon, Apr 30, 2018 at 12:42:16PM +0000, Matthew Wilcox wrote:
> On Mon, Apr 30, 2018 at 12:47:04PM +0300, Kirill A. Shutemov wrote:
> > On Wed, Apr 18, 2018 at 11:49:09AM -0700, Matthew Wilcox wrote:
> > > From: Matthew Wilcox <mawilcox@microsoft.com>
> > >
> > > This gives us five words of space in a single union in struct page.
> > > The compound_mapcount moves position (from offset 24 to offset 20)
> > > on 64-bit systems, but that does not seem likely to cause any trouble.
> >
> > Yeah, it should be fine.
> >
> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> I was wondering if it might make sense to make compound_mapcount an
> atomic_long_t. It'd guarantee no overflow, and prevent the location
> from moving.
It would only make sense if we change mapcount too.
I mean, what the point if the first split_huge_pmd() will cause the
overflow.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-04-30 13:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 18:48 [PATCH v3 00/14] Rearrange " Matthew Wilcox
2018-04-18 18:48 ` [PATCH v3 01/14] s390: Use _refcount for pgtables Matthew Wilcox
2018-04-18 18:49 ` [PATCH v3 02/14] mm: Split page_type out from _mapcount Matthew Wilcox
2018-04-19 9:04 ` Vlastimil Babka
2018-04-19 11:16 ` Matthew Wilcox
2018-04-20 15:17 ` Christopher Lameter
2018-04-20 20:43 ` Matthew Wilcox
2018-04-18 18:49 ` [PATCH v3 03/14] mm: Mark pages in use for page tables Matthew Wilcox
2018-04-19 9:30 ` Vlastimil Babka
2018-04-18 18:49 ` [PATCH v3 04/14] mm: Switch s_mem and slab_cache in struct page Matthew Wilcox
2018-04-19 11:06 ` Vlastimil Babka
2018-04-19 11:19 ` Matthew Wilcox
2018-04-18 18:49 ` [PATCH v3 05/14] mm: Move 'private' union within " Matthew Wilcox
2018-04-19 11:31 ` Vlastimil Babka
2018-04-20 15:25 ` Christopher Lameter
2018-04-20 20:27 ` Matthew Wilcox
2018-04-30 9:38 ` Kirill A. Shutemov
2018-04-18 18:49 ` [PATCH v3 06/14] mm: Move _refcount out of struct page union Matthew Wilcox
2018-04-19 11:37 ` Vlastimil Babka
2018-04-30 9:40 ` Kirill A. Shutemov
2018-04-18 18:49 ` [PATCH v3 07/14] slub: Remove page->counters Matthew Wilcox
2018-04-19 13:42 ` Vlastimil Babka
2018-04-19 14:23 ` Matthew Wilcox
2018-04-18 18:49 ` [PATCH v3 08/14] mm: Combine first three unions in struct page Matthew Wilcox
2018-04-19 13:46 ` Vlastimil Babka
2018-04-19 14:08 ` Matthew Wilcox
2018-04-30 9:42 ` Kirill A. Shutemov
2018-04-18 18:49 ` [PATCH v3 09/14] mm: Use page->deferred_list Matthew Wilcox
2018-04-19 13:23 ` Vlastimil Babka
2018-04-30 9:43 ` Kirill A. Shutemov
2018-04-18 18:49 ` [PATCH v3 10/14] mm: Move lru union within struct page Matthew Wilcox
2018-04-19 13:56 ` Vlastimil Babka
2018-04-30 9:44 ` Kirill A. Shutemov
2018-04-18 18:49 ` [PATCH v3 11/14] mm: Combine first two unions in " Matthew Wilcox
2018-04-19 14:03 ` Vlastimil Babka
2018-04-30 9:47 ` Kirill A. Shutemov
2018-04-30 12:42 ` Matthew Wilcox
2018-04-30 13:12 ` Kirill A. Shutemov [this message]
2018-04-18 18:49 ` [PATCH v3 12/14] mm: Improve struct page documentation Matthew Wilcox
2018-04-18 23:32 ` Randy Dunlap
2018-04-18 23:43 ` Matthew Wilcox
2018-04-18 18:49 ` [PATCH v3 13/14] slab,slub: Remove rcu_head size checks Matthew Wilcox
2018-04-18 18:49 ` [PATCH v3 14/14] slub: Remove kmem_cache->reserved Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430131232.vvfkl62d4nwskcsa@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kirill@shutemov.name \
--cc=laijs@cn.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=penberg@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox