From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f69.google.com (mail-lf0-f69.google.com [209.85.215.69]) by kanga.kvack.org (Postfix) with ESMTP id 7B13B6B0009 for ; Mon, 30 Apr 2018 06:04:53 -0400 (EDT) Received: by mail-lf0-f69.google.com with SMTP id m18-v6so2622990lfb.9 for ; Mon, 30 Apr 2018 03:04:53 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u23-v6sor209057ljk.102.2018.04.30.03.04.51 for (Google Transport Security); Mon, 30 Apr 2018 03:04:52 -0700 (PDT) Date: Mon, 30 Apr 2018 12:42:34 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH v3 08/14] mm: Combine first three unions in struct page Message-ID: <20180430094233.teyujjxupgt6d246@kshutemo-mobl1> References: <20180418184912.2851-1-willy@infradead.org> <20180418184912.2851-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180418184912.2851-9-willy@infradead.org> Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: linux-mm@kvack.org, Matthew Wilcox , Andrew Morton , "Kirill A . Shutemov" , Christoph Lameter , Lai Jiangshan , Pekka Enberg , Vlastimil Babka On Wed, Apr 18, 2018 at 11:49:06AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > By combining these three one-word unions into one three-word union, > we make it easier for users to add their own multi-word fields to struct > page, as well as making it obvious that SLUB needs to keep its double-word > alignment for its freelist & counters. > > No field moves position; verified with pahole. > > Signed-off-by: Matthew Wilcox Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov