From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jerome Glisse <jglisse@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Dave Chinner <david@fromorbit.com>,
linux-mm@kvack.org, lsf-pc@lists.linux-foundation.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-block@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [LSF/MM] schedule suggestion
Date: Thu, 19 Apr 2018 21:33:07 +0100 [thread overview]
Message-ID: <20180419203307.GJ30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180419172609.GD3519@redhat.com>
On Thu, Apr 19, 2018 at 01:26:10PM -0400, Jerome Glisse wrote:
> Basicly i want a callback in __fd_install(), do_dup2(), dup_fd() and
> add void * *private_data; to struct fdtable (also a default array to
> struct files_struct). The callback would be part of struct file_operations.
> and only call if it exist (os overhead is only for device driver that
> care).
Hell, *NO*. This is insane - you would need to maintain extra counts
("how many descriptors refer to this struct file... for this descriptor
table").
Besides, _what_ private_data? What would own and maintain it? A specific
driver? What if more than one of them wants that thing?
> Did i miss something fundamental ? copy_files() call dup_fd() so i
> should be all set here.
That looks like an extremely misguided kludge for hell knows what purpose,
almost certainly architecturally insane. What are you actually trying to
achieve?
next prev parent reply other threads:[~2018-04-19 20:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 21:19 Jerome Glisse
2018-04-19 0:48 ` Dave Chinner
2018-04-19 1:55 ` Dave Chinner
2018-04-19 14:38 ` Jerome Glisse
2018-04-19 14:43 ` Matthew Wilcox
2018-04-19 16:30 ` Jerome Glisse
2018-04-19 16:58 ` Jeff Layton
2018-04-19 17:26 ` Jerome Glisse
2018-04-19 18:31 ` Jeff Layton
2018-04-19 19:31 ` Jerome Glisse
2018-04-19 19:56 ` Matthew Wilcox
2018-04-19 20:15 ` Jerome Glisse
2018-04-19 20:25 ` Matthew Wilcox
2018-04-19 20:39 ` Al Viro
2018-04-19 21:08 ` Jerome Glisse
2018-04-19 20:51 ` Al Viro
2018-04-19 20:33 ` Al Viro [this message]
2018-04-19 20:58 ` Jerome Glisse
2018-04-19 21:21 ` Al Viro
2018-04-19 21:47 ` Jerome Glisse
2018-04-19 22:13 ` Al Viro
2018-04-19 14:51 ` Chris Mason
2018-04-19 15:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419203307.GJ30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=jglisse@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox