From: Li Wang <liwang@redhat.com>
To: mhocko@suse.com
Cc: linux-mm@kvack.org, ltp@lists.linux.it,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Zi Yan <zi.yan@cs.rutgers.edu>
Subject: [RFC PATCH] mm: correct status code which move_pages() returns for zero page
Date: Tue, 17 Apr 2018 19:06:15 +0800 [thread overview]
Message-ID: <20180417110615.16043-1-liwang@redhat.com> (raw)
move_pages(2) declears that status code for zero page is supposed to
be -EFAULT. But now it (LTP/move_pages04 test) gets -EPERM, the root
cause is that not goto out_flush after store_status() saves the err
which add_page_for_migration() returns for zero page.
LTP move_pages04:
TFAIL : move_pages04.c:143: status[1] is EPERM, expected EFAULT
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Zi Yan <zi.yan@cs.rutgers.edu>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index f65dd69..2b315fc 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1608,7 +1608,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
continue;
err = store_status(status, i, err, 1);
- if (err)
+ if (!err)
goto out_flush;
err = do_move_pages_to_node(mm, &pagelist, current_node);
--
2.9.5
next reply other threads:[~2018-04-17 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 11:06 Li Wang [this message]
2018-04-17 13:03 ` Michal Hocko
2018-04-17 14:14 ` Michal Hocko
2018-04-17 14:28 ` Li Wang
2018-04-17 19:00 ` Michal Hocko
2018-04-17 20:09 ` Zi Yan
2018-04-18 9:07 ` Michal Hocko
2018-04-18 9:19 ` Michal Hocko
2018-04-18 10:39 ` Li Wang
2018-04-18 11:29 ` Michal Hocko
2018-04-18 11:46 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417110615.16043-1-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=ltp@lists.linux.it \
--cc=mhocko@suse.com \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox