From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sasha Levin <Alexander.Levin@microsoft.com>,
Pavel Machek <pavel@ucw.cz>, Petr Mladek <pmladek@suse.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Dave Hansen <dave.hansen@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Peter Zijlstra <peterz@infradead.org>, Jan Kara <jack@suse.cz>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Byungchul Park <byungchul.park@lge.com>,
Tejun Heo <tj@kernel.org>, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes
Date: Mon, 16 Apr 2018 14:41:17 -0400 [thread overview]
Message-ID: <20180416144117.5757ee70@gandalf.local.home> (raw)
In-Reply-To: <CA+55aFzggPvS2MwFnKfXs6yHUQrbrJH7uyY4=znwetcdEXmZrw@mail.gmail.com>
On Mon, 16 Apr 2018 11:30:06 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, Apr 16, 2018 at 11:26 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > The problem is that it only fixed a critical bug, but didn't go far
> > enough to keep the bug fix from breaking API.
>
> An API breakage that gets noticed *is* a crtitical bug.
I totally agree with you. You misunderstood what I wrote.
I said there were two bugs here. The first bug was a possible accessing
bad memory bug. That needed to be fixed. The problem was by fixing
that, it broke API. But that's because the original code was broken
where it relied on broken code to get right. I never said the second
bug fix should not have been backported. I even said that the first bug
"didn't go far enough".
I hope the answer was not to revert the bug and put back the possible
bad memory access in to keep API. But it was to backport the second bug
fix that still has the first fix, but fixes the API breakage.
Yes, an API breakage is something I would label as critical to be
backported.
-- Steve
next prev parent reply other threads:[~2018-04-16 18:41 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180409001936.162706-1-alexander.levin@microsoft.com>
2018-04-09 0:19 ` Sasha Levin
2018-04-09 8:22 ` Petr Mladek
2018-04-15 14:42 ` Sasha Levin
2018-04-16 13:30 ` Steven Rostedt
2018-04-16 15:18 ` Linus Torvalds
2018-04-16 15:30 ` Pavel Machek
2018-04-16 15:50 ` Sasha Levin
2018-04-16 16:06 ` Pavel Machek
2018-04-16 16:14 ` Sasha Levin
2018-04-16 16:22 ` Steven Rostedt
2018-04-16 16:31 ` Sasha Levin
2018-04-16 16:47 ` Steven Rostedt
2018-04-16 16:53 ` Sasha Levin
2018-04-16 17:00 ` Pavel Machek
2018-04-17 10:46 ` Greg KH
2018-04-17 12:24 ` Petr Mladek
2018-04-17 12:49 ` Michal Hocko
2018-04-17 13:39 ` Sasha Levin
2018-04-17 14:22 ` Michal Hocko
2018-04-17 14:36 ` Sasha Levin
2018-04-17 18:10 ` Michal Hocko
2018-04-17 13:45 ` Sasha Levin
2018-04-18 8:33 ` Petr Mladek
2018-04-16 16:28 ` Pavel Machek
2018-04-16 16:39 ` Sasha Levin
2018-04-16 16:42 ` Pavel Machek
2018-04-16 16:45 ` Sasha Levin
2018-04-16 16:54 ` Pavel Machek
2018-04-17 10:50 ` Greg KH
2018-04-16 17:05 ` Pavel Machek
2018-04-16 17:16 ` Sasha Levin
2018-04-16 17:44 ` Steven Rostedt
2018-04-16 18:17 ` Sasha Levin
2018-04-16 18:35 ` Steven Rostedt
2018-04-16 20:17 ` Jiri Kosina
2018-04-16 20:36 ` Sasha Levin
2018-04-16 20:43 ` Jiri Kosina
2018-04-16 21:18 ` Sasha Levin
2018-04-16 21:28 ` Jiri Kosina
2018-04-17 10:39 ` Greg KH
2018-04-17 11:07 ` Michal Hocko
2018-04-17 14:04 ` Sasha Levin
2018-04-17 14:15 ` Steven Rostedt
2018-04-17 14:36 ` Greg KH
2018-04-17 14:36 ` Michal Hocko
2018-04-17 14:55 ` Sasha Levin
2018-04-17 15:52 ` Jiri Kosina
2018-04-17 16:06 ` Sasha Levin
2018-05-03 10:04 ` Pavel Machek
2018-05-03 13:02 ` Sasha Levin
2018-04-17 16:25 ` Mike Galbraith
2018-04-17 11:21 ` Jiri Kosina
2018-05-03 9:47 ` Pavel Machek
2018-05-03 13:06 ` Sasha Levin
2018-04-16 16:20 ` Steven Rostedt
2018-04-16 16:28 ` Sasha Levin
2018-04-16 16:39 ` Pavel Machek
2018-04-16 16:43 ` Sasha Levin
2018-04-16 16:53 ` Steven Rostedt
2018-04-16 16:58 ` Pavel Machek
2018-04-16 17:09 ` Sasha Levin
2018-04-16 17:33 ` Steven Rostedt
2018-04-16 17:42 ` Sasha Levin
2018-04-16 18:26 ` Steven Rostedt
2018-04-16 18:30 ` Linus Torvalds
2018-04-16 18:41 ` Steven Rostedt [this message]
2018-04-16 18:52 ` Linus Torvalds
2018-04-16 19:00 ` Linus Torvalds
2018-04-16 19:30 ` Steven Rostedt
2018-04-16 19:19 ` Linus Torvalds
2018-04-16 19:24 ` Steven Rostedt
2018-04-16 19:28 ` Linus Torvalds
2018-04-16 19:31 ` Linus Torvalds
2018-04-16 19:58 ` Steven Rostedt
2018-04-16 19:38 ` Steven Rostedt
2018-04-16 19:55 ` Linus Torvalds
2018-04-16 20:02 ` Steven Rostedt
2018-04-16 20:17 ` Linus Torvalds
2018-04-16 20:33 ` Jiri Kosina
2018-04-16 21:27 ` Steven Rostedt
2018-04-16 18:35 ` Sasha Levin
2018-04-16 18:57 ` Steven Rostedt
2018-04-16 15:36 ` Steven Rostedt
2018-04-16 16:02 ` Sasha Levin
2018-04-16 16:10 ` Pavel Machek
2018-04-16 16:12 ` Steven Rostedt
2018-04-16 16:19 ` Sasha Levin
2018-04-16 16:30 ` Steven Rostedt
2018-04-16 16:37 ` Sasha Levin
2018-04-16 17:06 ` Pavel Machek
2018-04-16 17:23 ` Sasha Levin
2018-04-17 11:41 ` Jan Kara
2018-04-17 13:31 ` Sasha Levin
2018-04-17 15:55 ` Jan Kara
2018-04-17 16:19 ` Sasha Levin
2018-04-17 17:57 ` Jan Kara
2018-04-17 18:28 ` Sasha Levin
2018-05-03 9:36 ` Pavel Machek
2018-05-03 13:28 ` Sasha Levin
2018-05-03 9:32 ` Pavel Machek
2018-05-03 13:30 ` Sasha Levin
2018-04-19 11:41 ` Thomas Backlund
2018-04-19 13:59 ` Greg KH
2018-04-19 14:05 ` Jan Kara
2018-04-19 14:22 ` Greg KH
2018-04-19 15:16 ` Thomas Backlund
2018-04-19 15:57 ` Greg KH
2018-04-19 16:25 ` Thomas Backlund
2018-04-19 16:41 ` Greg KH
2018-04-19 15:04 ` Thomas Backlund
2018-04-19 15:09 ` Sasha Levin
2018-04-19 16:20 ` Thomas Backlund
2018-04-16 15:39 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416144117.5757ee70@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Alexander.Levin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=byungchul.park@lge.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=pavel@ucw.cz \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox