linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: linux-mm@kvack.org
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Pavel Tatashin <pasha.tatashin@oracle.com>
Subject: [PATCH 7/8] mm: Always check PagePolicyNoCompound
Date: Fri, 13 Apr 2018 21:31:44 -0700	[thread overview]
Message-ID: <20180414043145.3953-8-willy@infradead.org> (raw)
In-Reply-To: <20180414043145.3953-1-willy@infradead.org>

From: Matthew Wilcox <mawilcox@microsoft.com>

Currently, we're only checking that a page is not compound when we're
setting or clearing a bit.  We should probably be checking the page
isn't compound when testing the bit too.

Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
---
 include/linux/page-flags.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index ac55f6c94c0a..1960b5e4b9ab 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -178,11 +178,10 @@ struct page *PagePolicyTailRead(struct page *page, bool modify)
 	return compound_head(page);
 }
 
-static __always_inline
-struct page *PagePolicyNoCompound(struct page *page, bool modify)
+static __always_inline struct page *PagePolicyNoCompound(struct page *page)
 {
 	CheckPageInit(page);
-	VM_BUG_ON_PGFLAGS(modify && PageCompound(page), page);
+	VM_BUG_ON_PGFLAGS(PageCompound(page), page);
 	return page;
 }
 
@@ -212,7 +211,7 @@ struct page *PagePolicyNoCompound(struct page *page, bool modify)
 #define PF_HEAD(page, modify)		compound_head(CheckPageInit(page))
 #define PF_ONLY_HEAD(page, modify)	PagePolicyOnlyHead(page)
 #define PF_TAIL_READ(page, modify)	PagePolicyTailRead(page, modify)
-#define PF_NO_COMPOUND(page, modify)	PagePolicyNoCompound(page, modify)
+#define PF_NO_COMPOUND(page, modify)	PagePolicyNoCompound(page)
 
 /*
  * Macros to create function definitions for page flags
-- 
2.16.3

  parent reply	other threads:[~2018-04-14  4:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14  4:31 [PATCH 0/8] Various PageFlags cleanups Matthew Wilcox
2018-04-14  4:31 ` [PATCH 1/8] mm: Rename PF argument to modify Matthew Wilcox
2018-04-14  4:31 ` [PATCH 2/8] mm: Rename PF_NO_TAIL to PF_TAIL_READ Matthew Wilcox
2018-04-14  4:31 ` [PATCH 3/8] mm: Turn PF_POISONED_CHECK into CheckPageInit Matthew Wilcox
2018-04-14  4:31 ` [PATCH 4/8] mm: Improve page flag policy documentation Matthew Wilcox
2018-04-14  4:31 ` [PATCH 5/8] mm: Fix bug in page flags checking Matthew Wilcox
2018-04-14  4:31 ` [PATCH 6/8] mm: Turn page policies into functions Matthew Wilcox
2018-04-16 12:46   ` Kirill A. Shutemov
2018-04-14  4:31 ` Matthew Wilcox [this message]
2018-04-16 12:51   ` [PATCH 7/8] mm: Always check PagePolicyNoCompound Kirill A. Shutemov
2018-04-17  1:05   ` [lkp-robot] [mm] 7df45c2b6a: kernel_BUG_at_include/linux/page-flags.h kernel test robot
2018-04-14  4:31 ` [PATCH 8/8] mm: Optimise PagePolicyTailRead Matthew Wilcox
2018-04-16 12:54 ` [PATCH 0/8] Various PageFlags cleanups Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180414043145.3953-8-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=mawilcox@microsoft.com \
    --cc=pasha.tatashin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox