From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Wei Wang <wei.w.wang@intel.com>,
virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, mhocko@kernel.org, pbonzini@redhat.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com,
huangzhichao@huawei.com
Subject: Re: [PATCH v29 1/4] mm: support reporting free page blocks
Date: Wed, 11 Apr 2018 02:25:33 +0300 [thread overview]
Message-ID: <20180411022440-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180410135429.d1aeeb91d7f2754ffe7fb80e@linux-foundation.org>
On Tue, Apr 10, 2018 at 01:54:29PM -0700, Andrew Morton wrote:
> On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> >
> > Andrew, were your questions answered? If yes could I bother you for an ack on this?
> >
>
> Still not very happy that readers are told that "this function may
> sleep" when it clearly doesn't do so. If we wish to be able to change
> it to sleep in the future then that should be mentioned. And even put a
> might_sleep() in there, to catch people who didn't read the comments...
>
> Otherwise it looks OK.
Oh, might_sleep with a comment explaining it's for the future sounds
good to me. I queued this - Wei, could you post a patch on top pls?
--
MST
next prev parent reply other threads:[~2018-04-10 23:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 2:39 [PATCH v29 0/4] Virtio-balloon: support free page reporting Wei Wang
2018-03-26 2:39 ` [PATCH v29 1/4] mm: support reporting free page blocks Wei Wang
2018-03-26 21:22 ` Andrew Morton
2018-03-27 6:23 ` Wei Wang
2018-03-27 6:33 ` Michal Hocko
2018-03-27 16:07 ` Michael S. Tsirkin
2018-03-28 7:01 ` Michal Hocko
2018-04-10 18:19 ` Michael S. Tsirkin
2018-04-10 20:54 ` Andrew Morton
2018-04-10 23:25 ` Michael S. Tsirkin [this message]
2018-04-11 1:22 ` Wei Wang
2018-03-26 2:39 ` [PATCH v29 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-03-26 2:39 ` [PATCH v29 3/4] mm/page_poison: expose page_poisoning_enabled to kernel modules Wei Wang
2018-03-26 3:24 ` Wang, Wei W
2018-03-26 21:24 ` Andrew Morton
2018-03-26 2:39 ` [PATCH v29 4/4] virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411022440-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=huangzhichao@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=quan.xu0@gmail.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox