From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 057D66B0007 for ; Tue, 10 Apr 2018 05:09:21 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id m6-v6so9029324pln.8 for ; Tue, 10 Apr 2018 02:09:20 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id g34-v6si2249904pld.24.2018.04.10.02.09.19 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 10 Apr 2018 02:09:20 -0700 (PDT) Date: Tue, 10 Apr 2018 11:09:17 +0200 From: Michal Hocko Subject: Re: [v3 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct Message-ID: <20180410090917.GZ21835@dhcp22.suse.cz> References: <1523310774-40300-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523310774-40300-1-git-send-email-yang.shi@linux.alibaba.com> Sender: owner-linux-mm@kvack.org List-ID: To: Yang Shi Cc: adobriyan@gmail.com, willy@infradead.org, mguzik@redhat.com, gorcunov@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue 10-04-18 05:52:54, Yang Shi wrote: [...] > So, introduce a new spinlock in mm_struct to protect the concurrent > access to arg_start|end, env_start|end and others except start_brk and > brk, which are still protected by mmap_sem to avoid concurrent access > from do_brk(). Is there any fundamental problem with brk using the same lock? -- Michal Hocko SUSE Labs