From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f72.google.com (mail-pl0-f72.google.com [209.85.160.72]) by kanga.kvack.org (Postfix) with ESMTP id 83A986B0003 for ; Mon, 9 Apr 2018 10:07:28 -0400 (EDT) Received: by mail-pl0-f72.google.com with SMTP id m6-v6so7047898pln.8 for ; Mon, 09 Apr 2018 07:07:28 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id y11si266782pgo.735.2018.04.09.07.07.26 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 09 Apr 2018 07:07:27 -0700 (PDT) Date: Mon, 9 Apr 2018 16:07:21 +0200 From: Michal Hocko Subject: Re: [PATCH 0/3] move __HAVE_ARCH_PTE_SPECIAL in Kconfig Message-ID: <20180409140721.GI21835@dhcp22.suse.cz> References: <1523282229-20731-1-git-send-email-ldufour@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523282229-20731-1-git-send-email-ldufour@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Laurent Dufour Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Jerome Glisse , aneesh.kumar@linux.vnet.ibm.com, akpm@linux-foundation.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, Jonathan Corbet , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Vineet Gupta , Palmer Dabbelt , Albert Ou , Martin Schwidefsky , Heiko Carstens On Mon 09-04-18 15:57:06, Laurent Dufour wrote: > The per architecture __HAVE_ARCH_PTE_SPECIAL is defined statically in the > per architecture header files. This doesn't allow to make other > configuration dependent on it. > > This series is moving the __HAVE_ARCH_PTE_SPECIAL into the Kconfig files, > setting it automatically when architectures was already setting it in > header file. > > There is no functional change introduced by this series. I would just fold all three patches into a single one. It is much easier to review that those selects are done properly when you can see that the define is set for the same architecture. In general, I like the patch. It is always quite painful to track per arch defines. > Laurent Dufour (3): > mm: introduce ARCH_HAS_PTE_SPECIAL > mm: replace __HAVE_ARCH_PTE_SPECIAL > mm: remove __HAVE_ARCH_PTE_SPECIAL > > Documentation/features/vm/pte_special/arch-support.txt | 2 +- > arch/arc/Kconfig | 1 + > arch/arc/include/asm/pgtable.h | 2 -- > arch/arm/Kconfig | 1 + > arch/arm/include/asm/pgtable-3level.h | 1 - > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/pgtable.h | 2 -- > arch/powerpc/Kconfig | 1 + > arch/powerpc/include/asm/book3s/64/pgtable.h | 3 --- > arch/powerpc/include/asm/pte-common.h | 3 --- > arch/riscv/Kconfig | 1 + > arch/s390/Kconfig | 1 + > arch/s390/include/asm/pgtable.h | 1 - > arch/sh/Kconfig | 1 + > arch/sh/include/asm/pgtable.h | 2 -- > arch/sparc/Kconfig | 1 + > arch/sparc/include/asm/pgtable_64.h | 3 --- > arch/x86/Kconfig | 1 + > arch/x86/include/asm/pgtable_types.h | 1 - > include/linux/pfn_t.h | 4 ++-- > mm/Kconfig | 3 +++ > mm/gup.c | 4 ++-- > mm/memory.c | 2 +- > 23 files changed, 18 insertions(+), 24 deletions(-) > > -- > 2.7.4 -- Michal Hocko SUSE Labs