From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "willy@infradead.org" <willy@infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"martin@lichtvoll.de" <martin@lichtvoll.de>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: Block layer use of __GFP flags
Date: Mon, 9 Apr 2018 08:53:49 +0200 [thread overview]
Message-ID: <20180409085349.31b10550@pentland.suse.de> (raw)
In-Reply-To: <63d16891d115de25ac2776088571d7e90dab867a.camel@wdc.com>
On Mon, 9 Apr 2018 04:46:22 +0000
"Bart Van Assche" <Bart.VanAssche@wdc.com> wrote:
> On Sun, 2018-04-08 at 12:08 -0700, Matthew Wilcox wrote:
> > On Sun, Apr 08, 2018 at 04:40:59PM +0000, Bart Van Assche wrote:
> > > Do you perhaps want me to prepare a patch that makes
> > > blk_get_request() again respect the full gfp mask passed as third
> > > argument to blk_get_request()?
> >
> > I think that would be a good idea. If it's onerous to have extra
> > arguments, there are some bits in gfp_flags which could be used for
> > your purposes.
>
> That's indeed something we can consider.
>
> It would be appreciated if you could have a look at the patch below.
>
> Thanks,
>
> Bart.
>
>
Why don't you fold the 'flags' argument into the 'gfp_flags', and drop
the 'flags' argument completely?
Looks a bit pointless to me, having two arguments denoting basically
the same ...
Cheers,
Hannes
next prev parent reply other threads:[~2018-04-09 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 6:54 Matthew Wilcox
2018-04-08 16:40 ` Bart Van Assche
2018-04-08 19:08 ` Matthew Wilcox
2018-04-09 4:46 ` Bart Van Assche
2018-04-09 6:53 ` Hannes Reinecke [this message]
2018-04-09 8:26 ` Christoph Hellwig
2018-04-09 15:11 ` Matthew Wilcox
2018-04-09 15:15 ` Bart Van Assche
2018-04-09 9:00 ` Michal Hocko
2018-04-09 15:03 ` Bart Van Assche
2018-04-09 17:31 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409085349.31b10550@pentland.suse.de \
--to=hare@suse.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@lichtvoll.de \
--cc=oleksandr@natalenko.name \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox