From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"willy@infradead.org" <willy@infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"martin@lichtvoll.de" <martin@lichtvoll.de>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: Block layer use of __GFP flags
Date: Mon, 9 Apr 2018 01:26:50 -0700 [thread overview]
Message-ID: <20180409082650.GA869@infradead.org> (raw)
In-Reply-To: <20180409085349.31b10550@pentland.suse.de>
On Mon, Apr 09, 2018 at 08:53:49AM +0200, Hannes Reinecke wrote:
> Why don't you fold the 'flags' argument into the 'gfp_flags', and drop
> the 'flags' argument completely?
> Looks a bit pointless to me, having two arguments denoting basically
> the same ...
Wrong way around. gfp_flags doesn't really make much sense in this
context. We just want the plain flags argument, including a non-block
flag for it.
next prev parent reply other threads:[~2018-04-09 8:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 6:54 Matthew Wilcox
2018-04-08 16:40 ` Bart Van Assche
2018-04-08 19:08 ` Matthew Wilcox
2018-04-09 4:46 ` Bart Van Assche
2018-04-09 6:53 ` Hannes Reinecke
2018-04-09 8:26 ` Christoph Hellwig [this message]
2018-04-09 15:11 ` Matthew Wilcox
2018-04-09 15:15 ` Bart Van Assche
2018-04-09 9:00 ` Michal Hocko
2018-04-09 15:03 ` Bart Van Assche
2018-04-09 17:31 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409082650.GA869@infradead.org \
--to=hch@infradead.org \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@lichtvoll.de \
--cc=oleksandr@natalenko.name \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox