From: Steven Rostedt <rostedt@goodmis.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Zhaoyang Huang <huangzhaoyang@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, kernel-patch-test@lists.linaro.org,
Andrew Morton <akpm@linux-foundation.org>,
Joel Fernandes <joelaf@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v1] kernel/trace:check the val against the available mem
Date: Fri, 30 Mar 2018 17:42:09 -0400 [thread overview]
Message-ID: <20180330174209.4cb77003@gandalf.local.home> (raw)
In-Reply-To: <20180330173031.257a491a@gandalf.local.home>
On Fri, 30 Mar 2018 17:30:31 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> I'll take a look at si_mem_available() that Joel suggested and see if
> we can make that work.
Wow, this appears to work great! Joel and Zhaoyang, can you test this?
-- Steve
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index a2fd3893cc02..32a803626ee2 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -1164,6 +1164,11 @@ static int __rb_allocate_pages(long nr_pages, struct list_head *pages, int cpu)
struct buffer_page *bpage, *tmp;
long i;
+ /* Check if the available memory is there first */
+ i = si_mem_available();
+ if (i < nr_pages)
+ return -ENOMEM;
+
for (i = 0; i < nr_pages; i++) {
struct page *page;
/*
next prev parent reply other threads:[~2018-03-30 21:42 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1522320104-6573-1-git-send-email-zhaoyang.huang@spreadtrum.com>
2018-03-30 14:20 ` Steven Rostedt
2018-03-30 16:37 ` Joel Fernandes
2018-03-30 19:10 ` Steven Rostedt
2018-03-30 20:37 ` Joel Fernandes
2018-03-30 20:53 ` Matthew Wilcox
2018-03-30 21:30 ` Steven Rostedt
2018-03-30 21:42 ` Steven Rostedt [this message]
2018-03-30 23:38 ` Joel Fernandes
2018-03-31 1:41 ` Steven Rostedt
2018-03-31 2:18 ` Matthew Wilcox
2018-03-31 3:07 ` Steven Rostedt
2018-03-31 5:44 ` Joel Fernandes
2018-04-02 0:52 ` Zhaoyang Huang
2018-04-03 11:06 ` Michal Hocko
2018-04-03 11:51 ` Steven Rostedt
2018-04-03 12:16 ` Michal Hocko
2018-04-03 12:23 ` Steven Rostedt
2018-04-03 12:35 ` Michal Hocko
2018-04-03 13:32 ` Steven Rostedt
2018-04-03 13:56 ` Michal Hocko
2018-04-03 14:17 ` Steven Rostedt
2018-04-03 16:11 ` Michal Hocko
2018-04-03 16:59 ` Steven Rostedt
2018-04-03 22:56 ` Steven Rostedt
2018-04-04 6:20 ` Michal Hocko
2018-04-04 12:21 ` Joel Fernandes
2018-04-04 12:59 ` Steven Rostedt
2018-04-04 14:10 ` Michal Hocko
2018-04-04 14:25 ` Steven Rostedt
2018-04-04 14:42 ` Michal Hocko
2018-04-04 15:04 ` Steven Rostedt
2018-04-04 15:27 ` Michal Hocko
2018-04-04 15:38 ` Steven Rostedt
2018-04-04 2:58 ` Zhaoyang Huang
2018-04-04 6:23 ` Michal Hocko
2018-04-04 9:29 ` Zhaoyang Huang
2018-04-04 14:11 ` Steven Rostedt
2018-04-04 14:23 ` Michal Hocko
2018-04-04 14:31 ` Steven Rostedt
2018-04-04 14:47 ` Michal Hocko
2018-04-04 15:47 ` Steven Rostedt
2018-04-05 2:58 ` Matthew Wilcox
2018-04-05 4:12 ` Joel Fernandes
2018-04-05 14:22 ` Matthew Wilcox
2018-04-05 14:27 ` Michal Hocko
2018-04-05 14:34 ` Steven Rostedt
2018-04-05 15:13 ` Matthew Wilcox
2018-04-05 15:32 ` Michal Hocko
2018-04-05 16:15 ` Matthew Wilcox
2018-04-05 18:54 ` Michal Hocko
2018-04-05 20:15 ` __GFP_LOW Matthew Wilcox
2018-04-06 6:09 ` __GFP_LOW Michal Hocko
2018-04-08 4:27 ` __GFP_LOW Matthew Wilcox
2018-04-09 7:34 ` __GFP_LOW Michal Hocko
2018-04-09 15:51 ` __GFP_LOW Matthew Wilcox
2018-04-09 18:14 ` __GFP_LOW Michal Hocko
2018-04-10 12:12 ` __GFP_LOW Дмитрий Леонтьев
2018-04-10 12:19 ` __GFP_LOW Matthew Wilcox
2018-04-10 12:13 ` __GFP_LOW Дмитрий Леонтьев
2018-04-05 14:30 ` [PATCH v1] kernel/trace:check the val against the available mem Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330174209.4cb77003@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=huangzhaoyang@gmail.com \
--cc=joelaf@google.com \
--cc=kernel-patch-test@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox