linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-pm@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] mm,oom: Do not unfreeze OOM victim thread.
Date: Thu, 29 Mar 2018 16:50:55 +0200	[thread overview]
Message-ID: <20180329145055.GH31039@dhcp22.suse.cz> (raw)
In-Reply-To: <1522334218-4268-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>

On Thu 29-03-18 23:36:58, Tetsuo Handa wrote:
> Currently, mark_oom_victim() calls __thaw_task() on the OOM victim
> threads and freezing_slow_path() unfreezes the OOM victim thread.
> But I think this exceptional behavior makes little sense nowadays.

Well, I would like to see this happen because it would allow more
changes on top. E.g. get rid of TIF_MEMDIE finally. But I am not really
sure we are there yet. OOM reaper is useful tool but it still cannot
help in some cases (shared memory, a lot of metadata allocated on behalf
of the process etc...). Considering that the freezing can be an
unprivileged operation (think cgroup freezer) then I am worried that
one container can cause the global oom killer and hide oom victims to
the fridge and spill over to other containers. Maybe I am overly
paranoid and this scenario is not even all that interesting but I would
like to hear a better justification which explains all these cases
rather than "we have oom reaper so we are good to go" rationale.
-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2018-03-29 14:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 14:36 Tetsuo Handa
2018-03-29 14:50 ` Michal Hocko [this message]
2018-03-29 15:52   ` Tetsuo Handa
2018-03-30 15:16 ` kbuild test robot
2018-03-30 15:43 ` kbuild test robot
2018-03-30 15:44 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329145055.GH31039@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox