From: Michal Hocko <mhocko@kernel.org>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"David Rientjes" <rientjes@google.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Christian König" <christian.koenig@amd.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Leon Romanovsky" <leonro@mellanox.com>,
"Artemy Kovalyov" <artemyko@mellanox.com>,
"Evgeny Baskakov" <ebaskakov@nvidia.com>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Mark Hairgrove" <mhairgrove@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sudeep Dutt" <sudeep.dutt@intel.com>,
"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
"Dimitri Sivanich" <sivanich@sgi.com>
Subject: Re: [RFC PATCH 0/3] mmu_notifier contextual information
Date: Mon, 26 Mar 2018 10:13:56 +0200 [thread overview]
Message-ID: <20180326081356.GA5652@dhcp22.suse.cz> (raw)
In-Reply-To: <20180323171748.20359-1-jglisse@redhat.com>
I haven't read through the whole thread, I just wanted to clarify the
OOM aspect.
On Fri 23-03-18 13:17:45, jglisse@redhat.com wrote:
[...]
> OOM is also an interesting case, recently a patchset was added to
> avoid OOM on a mm if a blocking mmu_notifier listener have been
> registered [1].
This is not quite right. We only skip oom _reaper_ (aka async oom victim
address space tear down). We still do allow such a task to be selected
as an OOM victim and killed. So the worst case that we might kill
another task if the current victim is not able to make a forward
progress on its own.
> This can be improve by adding a new OOM event type and
> having listener take special path on those. All mmu_notifier i know
> can easily have a special path for OOM that do not block (beside
> taking a short lived, across driver, spinlock). If mmu_notifier usage
> grows (from a point of view of more process using devices that rely on
> them) then we should also make sure OOM can do its bidding.
If we can distinguish the OOM path and enforce no locks or indirect
dependencies on the memory allocation the the situation would improve
for sure.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2018-03-26 8:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 17:17 jglisse
2018-03-23 17:17 ` [RFC PATCH 1/3] mm/mmu_notifier: use struct for invalidate_range_start/end parameters jglisse
2018-03-23 17:17 ` [RFC PATCH 2/3] mm/mmu_notifier: provide context information about range invalidation jglisse
2018-03-23 17:17 ` [RFC PATCH 3/3] mm/mmu_notifier: keep track of ranges being invalidated jglisse
2018-03-23 18:34 ` [RFC PATCH 0/3] mmu_notifier contextual information Christian König
2018-03-26 8:15 ` Michal Hocko
2018-03-26 8:13 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326081356.GA5652@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=alexander.deucher@amd.com \
--cc=artemyko@mellanox.com \
--cc=ashutosh.dixit@intel.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dennis.dalessandro@intel.com \
--cc=ebaskakov@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=joro@8bytes.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhairgrove@nvidia.com \
--cc=mike.marciniszyn@intel.com \
--cc=pbonzini@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=rientjes@google.com \
--cc=sivanich@sgi.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox