From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: mhocko@kernel.org, kirill.shutemov@linux.intel.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-mm@lists.ewheeler.net
Subject: Re: [PATCH] mm/shmem: Do not wait for lock_page() in shmem_unused_huge_shrink()
Date: Fri, 16 Mar 2018 16:34:17 +0300 [thread overview]
Message-ID: <20180316133417.hk2lvnvgildsc65n@node.shutemov.name> (raw)
In-Reply-To: <201803162214.ECJ30715.StOOFHOFVLJMQF@I-love.SAKURA.ne.jp>
On Fri, Mar 16, 2018 at 10:14:24PM +0900, Tetsuo Handa wrote:
> f2fs is doing
>
> page = f2fs_pagecache_get_page(inode->i_mapping, 0, FGP_LOCK|FGP_NOWAIT, 0);
>
> which calls
>
> struct page *pagecache_get_page(inode->i_mapping, 0, FGP_LOCK|FGP_NOWAIT, 0);
>
> . Then, can't we define
>
> static inline struct page *find_trylock_page(struct address_space *mapping,
> pgoff_t offset)
> {
> return pagecache_get_page(mapping, offset, FGP_LOCK|FGP_NOWAIT, 0);
> }
>
> and replace find_lock_page() with find_trylock_page() ?
This won't work in this case. We need to destinct no-page-in-page-cache
from failed-to-lock-page. We take different routes depending on this.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-03-16 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 10:59 Kirill A. Shutemov
2018-03-16 12:13 ` Michal Hocko
2018-03-16 12:25 ` Kirill A. Shutemov
2018-03-16 12:58 ` Michal Hocko
2018-03-16 13:02 ` Kirill A. Shutemov
2018-03-16 13:14 ` Tetsuo Handa
2018-03-16 13:20 ` Michal Hocko
2018-03-16 13:34 ` Kirill A. Shutemov [this message]
2018-03-16 14:42 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316133417.hk2lvnvgildsc65n@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mm@lists.ewheeler.net \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox