linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [memcg:since-4.15 382/386] arch/m68k/mm/init.c:125:0: warning: "UL" redefined
@ 2018-03-14 15:20 kbuild test robot
  2018-03-14 20:44 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-03-14 15:20 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: kbuild-all, linux-mm, Michal Hocko, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 3596 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.15
head:   5c3f7a041df707417532dd64b1d71fc29b24c0fe
commit: 145e9c14cca497b2d02f9edcf9307aad5946172f [382/386] linux/const.h: move UL() macro to include/linux/const.h
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 145e9c14cca497b2d02f9edcf9307aad5946172f
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All warnings (new ones prefixed by >>):

   arch/m68k/mm/init.c: In function 'print_memmap':
>> arch/m68k/mm/init.c:125:0: warning: "UL" redefined
    #define UL(x) ((unsigned long) (x))
    
   In file included from include/linux/list.h:8:0,
                    from include/linux/module.h:9,
                    from arch/m68k/mm/init.c:11:
   include/linux/const.h:6:0: note: this is the location of the previous definition
    #define UL(x)  (_UL(x))
    

vim +/UL +125 arch/m68k/mm/init.c

dd1cb3a7 Greg Ungerer 2012-10-24  122  
dd1cb3a7 Greg Ungerer 2012-10-24  123  void __init print_memmap(void)
dd1cb3a7 Greg Ungerer 2012-10-24  124  {
dd1cb3a7 Greg Ungerer 2012-10-24 @125  #define UL(x) ((unsigned long) (x))
dd1cb3a7 Greg Ungerer 2012-10-24  126  #define MLK(b, t) UL(b), UL(t), (UL(t) - UL(b)) >> 10
dd1cb3a7 Greg Ungerer 2012-10-24  127  #define MLM(b, t) UL(b), UL(t), (UL(t) - UL(b)) >> 20
dd1cb3a7 Greg Ungerer 2012-10-24  128  #define MLK_ROUNDUP(b, t) b, t, DIV_ROUND_UP(((t) - (b)), 1024)
dd1cb3a7 Greg Ungerer 2012-10-24  129  
dd1cb3a7 Greg Ungerer 2012-10-24  130  	pr_notice("Virtual kernel memory layout:\n"
dd1cb3a7 Greg Ungerer 2012-10-24  131  		"    vector  : 0x%08lx - 0x%08lx   (%4ld KiB)\n"
dd1cb3a7 Greg Ungerer 2012-10-24  132  		"    kmap    : 0x%08lx - 0x%08lx   (%4ld MiB)\n"
dd1cb3a7 Greg Ungerer 2012-10-24  133  		"    vmalloc : 0x%08lx - 0x%08lx   (%4ld MiB)\n"
dd1cb3a7 Greg Ungerer 2012-10-24  134  		"    lowmem  : 0x%08lx - 0x%08lx   (%4ld MiB)\n"
dd1cb3a7 Greg Ungerer 2012-10-24  135  		"      .init : 0x%p" " - 0x%p" "   (%4d KiB)\n"
dd1cb3a7 Greg Ungerer 2012-10-24  136  		"      .text : 0x%p" " - 0x%p" "   (%4d KiB)\n"
dd1cb3a7 Greg Ungerer 2012-10-24  137  		"      .data : 0x%p" " - 0x%p" "   (%4d KiB)\n"
dd1cb3a7 Greg Ungerer 2012-10-24  138  		"      .bss  : 0x%p" " - 0x%p" "   (%4d KiB)\n",
dd1cb3a7 Greg Ungerer 2012-10-24  139  		MLK(VECTORS, VECTORS + 256),
dd1cb3a7 Greg Ungerer 2012-10-24  140  		MLM(KMAP_START, KMAP_END),
dd1cb3a7 Greg Ungerer 2012-10-24  141  		MLM(VMALLOC_START, VMALLOC_END),
dd1cb3a7 Greg Ungerer 2012-10-24  142  		MLM(PAGE_OFFSET, (unsigned long)high_memory),
dd1cb3a7 Greg Ungerer 2012-10-24  143  		MLK_ROUNDUP(__init_begin, __init_end),
dd1cb3a7 Greg Ungerer 2012-10-24  144  		MLK_ROUNDUP(_stext, _etext),
dd1cb3a7 Greg Ungerer 2012-10-24  145  		MLK_ROUNDUP(_sdata, _edata),
dd1cb3a7 Greg Ungerer 2012-10-24  146  		MLK_ROUNDUP(__bss_start, __bss_stop));
dd1cb3a7 Greg Ungerer 2012-10-24  147  }
dd1cb3a7 Greg Ungerer 2012-10-24  148  

:::::: The code at line 125 was first introduced by commit
:::::: dd1cb3a7c43508c29e17836628090c0735bd3137 m68k: merge MMU and non-MMU versions of mm/init.c

:::::: TO: Greg Ungerer <gerg@uclinux.org>
:::::: CC: Geert Uytterhoeven <geert@linux-m68k.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 12291 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [memcg:since-4.15 382/386] arch/m68k/mm/init.c:125:0: warning: "UL" redefined
  2018-03-14 15:20 [memcg:since-4.15 382/386] arch/m68k/mm/init.c:125:0: warning: "UL" redefined kbuild test robot
@ 2018-03-14 20:44 ` Andrew Morton
  2018-03-15  8:39   ` Michal Hocko
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2018-03-14 20:44 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Masahiro Yamada, kbuild-all, linux-mm, Michal Hocko

On Wed, 14 Mar 2018 23:20:21 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.15
> head:   5c3f7a041df707417532dd64b1d71fc29b24c0fe
> commit: 145e9c14cca497b2d02f9edcf9307aad5946172f [382/386] linux/const.h: move UL() macro to include/linux/const.h
> config: m68k-sun3_defconfig (attached as .config)
> compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 145e9c14cca497b2d02f9edcf9307aad5946172f
>         # save the attached .config to linux build tree
>         make.cross ARCH=m68k 
> 
> All warnings (new ones prefixed by >>):
> 
>    arch/m68k/mm/init.c: In function 'print_memmap':
> >> arch/m68k/mm/init.c:125:0: warning: "UL" redefined
>     #define UL(x) ((unsigned long) (x))
>     
>    In file included from include/linux/list.h:8:0,
>                     from include/linux/module.h:9,
>                     from arch/m68k/mm/init.c:11:
>    include/linux/const.h:6:0: note: this is the location of the previous definition
>     #define UL(x)  (_UL(x))

That's OK - an unrelated patch in linux-next.patch removes that
#define.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [memcg:since-4.15 382/386] arch/m68k/mm/init.c:125:0: warning: "UL" redefined
  2018-03-14 20:44 ` Andrew Morton
@ 2018-03-15  8:39   ` Michal Hocko
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2018-03-15  8:39 UTC (permalink / raw)
  To: Andrew Morton; +Cc: kbuild test robot, Masahiro Yamada, kbuild-all, linux-mm

On Wed 14-03-18 13:44:45, Andrew Morton wrote:
> On Wed, 14 Mar 2018 23:20:21 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-4.15
> > head:   5c3f7a041df707417532dd64b1d71fc29b24c0fe
> > commit: 145e9c14cca497b2d02f9edcf9307aad5946172f [382/386] linux/const.h: move UL() macro to include/linux/const.h
> > config: m68k-sun3_defconfig (attached as .config)
> > compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout 145e9c14cca497b2d02f9edcf9307aad5946172f
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=m68k 
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    arch/m68k/mm/init.c: In function 'print_memmap':
> > >> arch/m68k/mm/init.c:125:0: warning: "UL" redefined
> >     #define UL(x) ((unsigned long) (x))
> >     
> >    In file included from include/linux/list.h:8:0,
> >                     from include/linux/module.h:9,
> >                     from arch/m68k/mm/init.c:11:
> >    include/linux/const.h:6:0: note: this is the location of the previous definition
> >     #define UL(x)  (_UL(x))
> 
> That's OK - an unrelated patch in linux-next.patch removes that
> #define.
> 

I have cherry-picked 445420c31cbba4a218b432bece0b500b6c4f9d63 into my
mmotm git tree. Thanks for pointing that out.

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-15  8:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-14 15:20 [memcg:since-4.15 382/386] arch/m68k/mm/init.c:125:0: warning: "UL" redefined kbuild test robot
2018-03-14 20:44 ` Andrew Morton
2018-03-15  8:39   ` Michal Hocko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox