From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCHv3 0/2] zsmalloc/zram: drop zram's max_zpage_size
Date: Thu, 15 Mar 2018 00:07:13 +0900 [thread overview]
Message-ID: <20180314150713.GA144952@rodete-laptop-imager.corp.google.com> (raw)
In-Reply-To: <20180314081833.1096-1-sergey.senozhatsky@gmail.com>
On Wed, Mar 14, 2018 at 05:18:31PM +0900, Sergey Senozhatsky wrote:
> Hello,
>
> ZRAM's max_zpage_size is a bad thing. It forces zsmalloc to
> store normal objects as huge ones, which results in bigger zsmalloc
> memory usage. Drop it and use actual zsmalloc huge-class value when
> decide if the object is huge or not.
>
> v3:
> - add pool param to zs_huge_class_size() [Minchan]
>
> Sergey Senozhatsky (2):
> zsmalloc: introduce zs_huge_class_size() function
> zram: drop max_zpage_size and use zs_huge_class_size()
Both looks good to me.
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks.
next prev parent reply other threads:[~2018-03-14 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 8:18 Sergey Senozhatsky
2018-03-14 8:18 ` [PATCHv3 1/2] zsmalloc: introduce zs_huge_class_size() function Sergey Senozhatsky
2018-03-14 8:18 ` [PATCHv3 2/2] zram: drop max_zpage_size and use zs_huge_class_size() Sergey Senozhatsky
2018-03-14 15:07 ` Minchan Kim [this message]
2018-03-15 0:55 ` [PATCHv3 0/2] zsmalloc/zram: drop zram's max_zpage_size Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314150713.GA144952@rodete-laptop-imager.corp.google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox