From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>
Subject: Re: [PATCHv2 2/2] zram: drop max_zpage_size and use zs_huge_class_size()
Date: Tue, 13 Mar 2018 19:24:37 +0900 [thread overview]
Message-ID: <20180313102437.GA5114@jagdpanzerIV> (raw)
In-Reply-To: <20180313090249.GA240650@rodete-desktop-imager.corp.google.com>
Hello Minchan,
On (03/13/18 18:02), Minchan Kim wrote:
> Sorry for being late.
> I love this patchset! Just a minor below.
:)
[..]
> > + if (!huge_class_size)
> > + huge_class_size = zs_huge_class_size();
>
> If it is static, we can do this in zram_init? I believe it's more readable in that
> it's never changed betweens zram instances.
We need to have at least one pool, because pool decides where the
watermark is. At zram_init() stage we don't have a pool yet. We
zs_create_pool() in zram_meta_alloc() so that's why I put
zs_huge_class_size() there. I'm not in love with it, but that's
the only place where we can have it.
-ss
next prev parent reply other threads:[~2018-03-13 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 7:06 [PATCHv2 0/2] zsmalloc/zram: drop zram's max_zpage_size Sergey Senozhatsky
2018-03-06 7:06 ` [PATCHv2 1/2] zsmalloc: introduce zs_huge_class_size() function Sergey Senozhatsky
2018-03-06 7:06 ` [PATCHv2 2/2] zram: drop max_zpage_size and use zs_huge_class_size() Sergey Senozhatsky
2018-03-13 9:02 ` Minchan Kim
2018-03-13 10:24 ` Sergey Senozhatsky [this message]
2018-03-13 13:58 ` Minchan Kim
2018-03-13 14:18 ` Sergey Senozhatsky
2018-03-13 14:29 ` Minchan Kim
2018-03-13 14:35 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313102437.GA5114@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox