From: Matthew Wilcox <willy@infradead.org>
To: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Removing GFP_NOFS
Date: Thu, 8 Mar 2018 15:46:18 -0800 [thread overview]
Message-ID: <20180308234618.GE29073@bombadil.infradead.org> (raw)
Do we have a strategy for eliminating GFP_NOFS?
As I understand it, our intent is to mark the areas in individual
filesystems that can't be reentered with memalloc_nofs_save()/restore()
pairs. Once they're all done, then we can replace all the GFP_NOFS
users with GFP_KERNEL.
How will we know when we're done and can kill GFP_NOFS? I was thinking
that we could put a warning in slab/page_alloc that fires when __GFP_IO
is set, __GFP_FS is clear and PF_MEMALLOC_NOFS is clear. That would
catch every place that uses GFP_NOFS without using memalloc_nofs_save().
Unfortunately (and this is sort of the point), there's a lot of places
which use GFP_NOFS as a precaution; that is, they can be called from
places which both are and aren't in a nofs path. So we'd have to pass
in GFP flags. Which would be a lot of stupid churn.
I don't have a good solution here. Maybe this is a good discussion
topic for LSFMM, or maybe there's already a good solution I'm overlooking.
next reply other threads:[~2018-03-08 23:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 23:46 Matthew Wilcox [this message]
2018-03-09 1:35 ` Dave Chinner
2018-03-09 4:06 ` Dave Chinner
2018-03-09 11:14 ` Tetsuo Handa
2018-03-09 14:48 ` Goldwyn Rodrigues
2018-03-09 22:38 ` Dave Chinner
2018-03-10 2:44 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308234618.GE29073@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox