linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ram Pai <linuxram@us.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Li Wang <liwang@redhat.com>, Jan Stancek <jstancek@redhat.com>,
	ltp@lists.linux.it, linux-mm@kvack.org,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [bug?] Access was denied by memory protection keys in execute-only address
Date: Thu, 8 Mar 2018 08:45:45 -0800	[thread overview]
Message-ID: <20180308164545.GM1060@ram.oc3035372033.ibm.com> (raw)
In-Reply-To: <871sguep4v.fsf@concordia.ellerman.id.au>

On Thu, Mar 08, 2018 at 11:19:12PM +1100, Michael Ellerman wrote:
> Li Wang <liwang@redhat.com> writes:
> > Hi,
> >
> > ltp/mprotect04[1] crashed by SEGV_PKUERR on ppc64(LPAR on P730, Power 8
> > 8247-22L) with kernel-v4.16.0-rc4.
> >
> > 10000000-10020000 r-xp 00000000 fd:00 167223           mprotect04
> > 10020000-10030000 r--p 00010000 fd:00 167223           mprotect04
> > 10030000-10040000 rw-p 00020000 fd:00 167223           mprotect04
> > 1001a380000-1001a3b0000 rw-p 00000000 00:00 0          [heap]
> > 7fffa6c60000-7fffa6c80000 --xp 00000000 00:00 0 a??
> >
> > a??&exec_func = 0x10030170a??
> >
> > a??&func = 0x7fffa6c60170a??
> >
> > a??While perform a??
> > "(*func)();" we get the
> > a??segmentation fault.
> > a??
> >
> > a??strace log:a??
> >
> > -------------------
> > a??mprotect(0x7fffaed00000, 131072, PROT_EXEC) = 0
> > rt_sigprocmask(SIG_BLOCK, NULL, [], 8)  = 0
> > --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_PKUERR, si_addr=0x7fffaed00170}
> > ---a??
> 
> Looks like a bug to me.
> 
> Please Cc linuxppc-dev on powerpc bugs.
> 
> I also can't reproduce this failure on my machine.
> Not sure what's going on?

I could reproduce it on a power7 lpar.  But not on a power8 lpar.

The problem seems to be that the cpu generates a key exception if
the page with Read/Write-disable-but-execute-enable key is executed
on power7. If I enable read on that key, the exception disappears.

BTW: the testcase executes mprotect(..,PROT_EXEC).
The mprotect(, PROT_EXEC) system call internally generates a
execute-only key and associates it with the pages in the address-range.

Now since Li Wang claims that he can reproduce it on power8 as well, i
am wondering if the slightly different cpu behavior is dependent on the
version of the firmware/microcode?


RP

  reply	other threads:[~2018-03-08 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07  8:09 Li Wang
2018-03-08  0:43 ` Ram Pai
2018-03-08  3:38   ` Li Wang
2018-03-08 12:19 ` Michael Ellerman
2018-03-08 16:45   ` Ram Pai [this message]
2018-03-09  3:43     ` Li Wang
2018-03-09  5:50       ` Ram Pai
2018-03-20 21:58       ` Ram Pai
2018-03-21  6:53         ` Li Wang
2018-03-22  7:09           ` Ram Pai
2018-03-23  9:27             ` Li Wang
2018-03-24  0:44               ` Ram Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308164545.GM1060@ram.oc3035372033.ibm.com \
    --to=linuxram@us.ibm.com \
    --cc=jstancek@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox