From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 414BE6B0003 for ; Thu, 8 Mar 2018 00:07:16 -0500 (EST) Received: by mail-pf0-f198.google.com with SMTP id j12so2386291pff.18 for ; Wed, 07 Mar 2018 21:07:16 -0800 (PST) Received: from ozlabs.org (ozlabs.org. [2401:3900:2:1::2]) by mx.google.com with ESMTPS id t8-v6si1889950plz.495.2018.03.07.21.07.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Mar 2018 21:07:14 -0800 (PST) Date: Thu, 8 Mar 2018 16:06:50 +1100 From: Stephen Rothwell Subject: Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg) Message-ID: <20180308160650.6c62683e@canb.auug.org.au> In-Reply-To: <20180307184141.3dff2f6c0f7d415912e50030@linux-foundation.org> References: <20180308002016.L3JwBaNZ9%akpm@linux-foundation.org> <41ec9eeb-f0bf-e26d-e3ae-4a684c314360@infradead.org> <20180307184141.3dff2f6c0f7d415912e50030@linux-foundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/7/NY81eOkhTXLaucIb0LHt4"; protocol="application/pgp-signature" Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Randy Dunlap , broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, Shakeel Butt --Sig_/7/NY81eOkhTXLaucIb0LHt4 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Andrew, On Wed, 7 Mar 2018 18:41:41 -0800 Andrew Morton = wrote: > > On Wed, 7 Mar 2018 18:20:12 -0800 Randy Dunlap wr= ote: >=20 > > On 03/07/2018 04:20 PM, akpm@linux-foundation.org wrote: =20 > > > The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to > > >=20 > > > http://www.ozlabs.org/~akpm/mmotm/ > > >=20 > > > mmotm-readme.txt says > > >=20 > > > README for mm-of-the-moment: > > >=20 > > > http://www.ozlabs.org/~akpm/mmotm/ > > >=20 > > > This is a snapshot of my -mm patch queue. Uploaded at random hopeful= ly > > > more than once a week. =20 > >=20 > > UML on i386 and/or x86_64: > >=20 > > defconfig, CONFIG_MEMCG is not set: > >=20 > > ../fs/notify/group.c: In function 'fsnotify_final_destroy_group': > > ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete = type > > css_put(&group->memcg->css); =20 >=20 > oops. >=20 > From: Andrew Morton > Subject: fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix >=20 > fix CONFIG_MEMCG=3Dn build >=20 > Reported-by: Randy Dunlap > Cc: Amir Goldstein > Cc: Christoph Lameter > Cc: David Rientjes > Cc: Greg Thelen > Cc: Jan Kara > Cc: Johannes Weiner > Cc: Joonsoo Kim > Cc: Mel Gorman > Cc: Michal Hocko > Cc: Pekka Enberg > Cc: Shakeel Butt > Cc: Vladimir Davydov > Cc: Vlastimil Babka > Signed-off-by: Andrew Morton > --- >=20 > fs/notify/group.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > --- a/fs/notify/group.c~fs-fsnotify-account-fsnotify-metadata-to-kmemcg-f= ix > +++ a/fs/notify/group.c > @@ -38,7 +38,7 @@ static void fsnotify_final_destroy_group > group->ops->free_group_priv(group); > =20 > if (group->memcg) > - css_put(&group->memcg->css); > + mem_cgroup_put(group->memcg); > =20 > kfree(group); > } I have applied that to linux-next today. --=20 Cheers, Stephen Rothwell --Sig_/7/NY81eOkhTXLaucIb0LHt4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlqgxOoACgkQAVBC80lX 0GyQWwf+OOTRT0HPC735Gokgc+/Y8u9pLLyug4KOqXIfCRPYrP++L7efcpPd6l6u yN50iQc1S0G+j6D63YmvasTWrwfuRas2IwFa7oidgTWBfNg+0Jp77zrNS68HOXCh t0YhG70DJGOuH56DFjSQuGiYwfRwax4JzdC19YIokMnhtUGVn+fW9LCepA7xSn8t 6nIApzXiVDUE9DoPukl62eo+RnHTEzAWCjKwPLPSrQBnkJQUQxEO2lTuXxOcbAjM RVLEXCcdTaVPjL8//1jFqs/X1EUgpdSkypyZku0sdpmjgQqVTXuJLVudY3DeobIx OzG/NrpPzcgwYUNfrLASML9iKqyQkA== =tnki -----END PGP SIGNATURE----- --Sig_/7/NY81eOkhTXLaucIb0LHt4--