From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 1CA006B0006 for ; Wed, 7 Mar 2018 21:41:46 -0500 (EST) Received: by mail-wr0-f199.google.com with SMTP id j4so2282853wrg.11 for ; Wed, 07 Mar 2018 18:41:46 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id 93si14087165wrj.382.2018.03.07.18.41.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 18:41:44 -0800 (PST) Date: Wed, 7 Mar 2018 18:41:41 -0800 From: Andrew Morton Subject: Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg) Message-Id: <20180307184141.3dff2f6c0f7d415912e50030@linux-foundation.org> In-Reply-To: <41ec9eeb-f0bf-e26d-e3ae-4a684c314360@infradead.org> References: <20180308002016.L3JwBaNZ9%akpm@linux-foundation.org> <41ec9eeb-f0bf-e26d-e3ae-4a684c314360@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Randy Dunlap Cc: broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Shakeel Butt On Wed, 7 Mar 2018 18:20:12 -0800 Randy Dunlap wrote: > On 03/07/2018 04:20 PM, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > more than once a week. > > UML on i386 and/or x86_64: > > defconfig, CONFIG_MEMCG is not set: > > ../fs/notify/group.c: In function 'fsnotify_final_destroy_group': > ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type > css_put(&group->memcg->css); oops. From: Andrew Morton Subject: fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix fix CONFIG_MEMCG=n build Reported-by: Randy Dunlap Cc: Amir Goldstein Cc: Christoph Lameter Cc: David Rientjes Cc: Greg Thelen Cc: Jan Kara Cc: Johannes Weiner Cc: Joonsoo Kim Cc: Mel Gorman Cc: Michal Hocko Cc: Pekka Enberg Cc: Shakeel Butt Cc: Vladimir Davydov Cc: Vlastimil Babka Signed-off-by: Andrew Morton --- fs/notify/group.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/notify/group.c~fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix +++ a/fs/notify/group.c @@ -38,7 +38,7 @@ static void fsnotify_final_destroy_group group->ops->free_group_priv(group); if (group->memcg) - css_put(&group->memcg->css); + mem_cgroup_put(group->memcg); kfree(group); } _