From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f200.google.com (mail-wr0-f200.google.com [209.85.128.200]) by kanga.kvack.org (Postfix) with ESMTP id 65D836B0003 for ; Tue, 6 Mar 2018 10:01:17 -0500 (EST) Received: by mail-wr0-f200.google.com with SMTP id z14so13513649wrh.1 for ; Tue, 06 Mar 2018 07:01:17 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u59sor8903742edc.53.2018.03.06.07.01.15 for (Google Transport Security); Tue, 06 Mar 2018 07:01:15 -0800 (PST) Date: Tue, 6 Mar 2018 18:00:59 +0300 From: "Kirill A. Shutemov" Subject: Re: [RFC, PATCH 13/22] mm, rmap: Free encrypted pages once mapcount drops to zero Message-ID: <20180306150059.fclktp7qdhy37vyz@node.shutemov.name> References: <20180305162610.37510-1-kirill.shutemov@linux.intel.com> <20180305162610.37510-14-kirill.shutemov@linux.intel.com> <20180306082743.2epdfxv4ds7hz7py@node.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: "Kirill A. Shutemov" , Ingo Molnar , x86@kernel.org, Thomas Gleixner , "H. Peter Anvin" , Tom Lendacky , Kai Huang , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Tue, Mar 06, 2018 at 06:59:04AM -0800, Dave Hansen wrote: > On 03/06/2018 12:27 AM, Kirill A. Shutemov wrote: > > + anon_vma = page_anon_vma(page); > > + if (anon_vma_encrypted(anon_vma)) { > > + int keyid = anon_vma_keyid(anon_vma); > > + free_encrypt_page(page, keyid, compound_order(page)); > > + } > > } > > So, just double-checking: free_encrypt_page() neither "frees and > encrypts the page"" nor "free an encrypted page"? > > That seems a bit suboptimal. :) Yes, I'm bad with words :) -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org